Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zebra: changes for code maintainability #16041

Merged
merged 1 commit into from
Jul 25, 2024
Merged

zebra: changes for code maintainability #16041

merged 1 commit into from
Jul 25, 2024

Conversation

sri-mohan1
Copy link
Contributor

these changes are for improving the code maintainability and readability

@frrbot frrbot bot added the zebra label May 19, 2024
@sri-mohan1
Copy link
Contributor Author

ci:rerun

@ton31337
Copy link
Member

Please fix the formatting/styling also.

@sri-mohan1
Copy link
Contributor Author

Please fix the formatting/styling also.

Sure Mr. @ton31337 . thanks

@github-actions github-actions bot added size/L and removed size/M labels May 23, 2024
@sri-mohan1
Copy link
Contributor Author

Please fix the formatting/styling also.

Hi Mr. @ton31337, corrected the code formatting/styling as mentioned.
Kindly review the changes.

@sri-mohan1
Copy link
Contributor Author

ci:rerun

@sri-mohan1
Copy link
Contributor Author

Kindly review, thanks
@donaldsharp @ton31337 @riw777

@sri-mohan1
Copy link
Contributor Author

Hi Mr. @ton31337 ,
Thanks for your review and approving the changes.
It is been pending from few days.
Can you please help to merge the changes, i have few more changes to submit in pipeline.
thanks.

@sri-mohan1
Copy link
Contributor Author

ci:rerun

mobash-rasool
mobash-rasool requested changes Jul 2, 2024
View reviewed changes
zebra/zebra_vxlan_if.c Outdated
@@ -493,8 +486,7 @@ static int zebra_vxlan_if_vni_entry_add(struct zebra_if *zif,
}

static int zebra_vxlan_if_add_update_vni(struct zebra_if *zif,
struct zebra_vxlan_vni *vni,
void *ctxt)
struct zebra_vxlan_vni *vni, void *ctxt)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert this change? This will make the lines go more than 80 chars. Similar comment for other lines as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mobash,
Corrected as per the suggestion.

@github-actions github-actions bot added size/M rebase PR needs rebase and removed size/L labels Jul 2, 2024
@sri-mohan1 sri-mohan1 requested a review from mobash-rasool July 3, 2024 05:32
@github-actions github-actions bot added size/S and removed size/M labels Jul 3, 2024
@mobash-rasool
Copy link
Contributor

ci:rerun

1 similar comment
@sri-mohan1
Copy link
Contributor Author

ci:rerun

@sri-mohan1
zebra: changes for code maintainability
c2f2dde 
these changes are for improving the code maintainability and readability

Signed-off-by: sri-mohan1 <[email protected]>
@sri-mohan1
Copy link
Contributor Author

ci:rerun

1 similar comment
@sri-mohan1
Copy link
Contributor Author

ci:rerun

@mobash-rasool mobash-rasool merged commit 3ddf5cf into FRRouting:master Jul 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mobash-rasool mobash-rasool mobash-rasool approved these changes

@ton31337 ton31337 ton31337 approved these changes

Assignees
No one assigned
Labels
master rebase PR needs rebase size/S zebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sri-mohan1 @ton31337 @mobash-rasool