isis, lib: add isis srv6 end sid to ls_prefix #15797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found it, I only had to parse the locator TLV from the LSP. |
pguibert6WIND
force-pushed
the
isis_srv6_ls_subnet
branch
from
90f5312 to
56600ce
Compare
cscarpitta
reviewed
Jun 24, 2024
lib/link_state.c
Outdated
| json_object_object_add(json, "segment-routing-ipv6", jsrv6); | ||
| snprintfrr(buf, INET6_BUFSIZ, "%pI6", &pref->srv6.sid); | ||
| json_object_string_add(jsrv6, "sid", buf); | ||
| json_object_string_add(jsrv6, "sid", |
There was a problem hiding this comment.
The name of this json field is incorrect. It should be "endpoint-behavior" or "behavior".
There was a problem hiding this comment.
replaced with behavior
isisd/isis_te.c
Outdated
| memcpy(&sr.sid, &psid->sid, sizeof(struct in6_addr)); | ||
|
|
||
| if (!CHECK_FLAG(ls_pref->flags, LS_PREF_SRV6) || | ||
| !memcmp(&ls_pref->srv6, &sr, sizeof(struct ls_srv6_sid))) { |
There was a problem hiding this comment.
Here, shouldn't be the opposite?
Suggested change
| !memcmp(&ls_pref->srv6, &sr, sizeof(struct ls_srv6_sid))) { | |
| memcmp(&ls_pref->srv6, &sr, sizeof(struct ls_srv6_sid))) { |
We are comparing the new SID sr that we received from the LSP with the SID we already had ls_pref->srv6.
If memcmp(...) != 0, it means the SID has changed, and therefore we need to update ls_pref->srv6.
pguibert6WIND
force-pushed
the
isis_srv6_ls_subnet
branch
from
56600ce to
6a6abad
Compare
|
ci:rerun |
pguibert6WIND
force-pushed
the
isis_srv6_ls_subnet
branch
from
6a6abad to
ac10c04
Compare
According to draft-ietf-lsr-isis-srv6-extensions draft, the End SID should be available in link state prefix information. Add the SID information in the link state prefix, by getting the END SID from the locator TLV information. Signed-off-by: Philippe Guibert <[email protected]>
pguibert6WIND
force-pushed
the
isis_srv6_ls_subnet
branch
from
ac10c04 to
4e76df0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to draft-ietf-lsr-isis-srv6-extensions draft, the End SID should be available in link state prefix information. Add the SID information in the link state prefix.
I have however a problem. how to test it .. I tried , but without success:
Observed
Expected: