Mimic GNU basename() API for non-glibc library e.g. musl

[kraj]

musl only provides POSIX version of basename and it has also removed providing it via string.h header [1] which now results in compile errors with newer compilers e.g. clang-18

[1] https://git.musl-libc.org/cgit/musl/commit/?id=725e17ed6dff4d0cd22487bb64470881e86a92e7

[ton31337]

Even more, we have compile errors:

15-Mar-2024 21:40:56 	In file included from zebra/zapi_msg.c:12:
15-Mar-2024 21:40:56 	./lib/zebra.h:230:36: error: expected declaration specifiers or '...' before '/'
15-Mar-2024 21:40:56 	  230 | #define basename(src) (strrchr(src,'/') ? strrchr(src,'/')+1 : src)
15-Mar-2024 21:40:56 	      |                                    ^~~
15-Mar-2024 21:40:56 	./lib/zebra.h:230:41: error: expected ')' before '?' token
15-Mar-2024 21:40:56 	  230 | #define basename(src) (strrchr(src,'/') ? strrchr(src,'/')+1 : src)
15-Mar-2024 21:40:56 	      |                                         ^
15-Mar-2024 21:40:56 	  CC       zebra/zebra_affinitymap.o
15-Mar-2024 21:40:56 	In file included from /usr/include/stdint.h:32,
15-Mar-2024 21:40:56 	                 from /usr/local/lib/gcc12/gcc/x86_64-portbld-freebsd14.0/12.2.0/include/stdint.h:9,
15-Mar-2024 21:40:56 	                 from ./lib/compiler.h:366,
15-Mar-2024 21:40:56 	                 from ./lib/zebra.h:13:
15-Mar-2024 21:40:56 	zebra/zapi_msg.c: In function 'zserv_encode_vrf':
15-Mar-2024 21:40:56 	zebra/zapi_msg.c:105:44: error: 'basename' undeclared (first use in this function)
15-Mar-2024 21:40:56 	  105 |                 strlcpy(data.l.netns_name, basename((char *)netns_name),
15-Mar-2024 21:40:56 	      |                                            ^~~~~~~~
15-Mar-2024 21:40:56 	zebra/zapi_msg.c:105:44: note: each undeclared identifier is reported only once for each function it appears in

[ton31337]

Just loudly thinking, if we need to add an additional check here:

#ifndef basename
    #define basename(src) (strrchr(src,'/') ? strrchr(src,'/')+1 : src)
#endif

[kraj]

what would that get us ? it is in a .c source file unless its included multiple times, it wont be useful.

[mwinter-osr]

CI:rerun Rerun after fixing git access on CI infra

[Jafaral]

@kraj can you please rebase on top of master? will try to get his in.

[kraj]

@kraj can you please rebase on top of master? will try to get his in.

done

[Jafaral]

minor nit by the linter

  #if !defined(__GLIBC__)
-#define basename(src) (strrchr(src,'/') ? strrchr(src,'/')+1 : src)
+#define basename(src) (strrchr(src, '/') ? strrchr(src, '/') + 1 : src)
 #endif
 

[Jafaral]

Thank you @kraj. Ping me if you need any help to get FRR on OE side.

[Jafaral]

Oh, BTW, would love to see 10.1 on scarthgap. I can backport this to 10.1 if that helps.

[kraj]

Oh, BTW, would love to see 10.1 on scarthgap. I can backport this to 10.1 if that helps.

We are on 10.0.1 atm, isnt 10.1 a major release compared to 10.0 ? if not then its easier to get it in if major release its against the policy sadly but we can make a case if there are critical fixes and features in 10.1

[Jafaral]

10.1 is a minor release. 10.0 was a major release mainly due to the push for support NB interface. 10.1 improves on that.

[kraj]

10.1 is a minor release. 10.0 was a major release mainly due to the push for support NB interface. 10.1 improves on that.

thanks please push this change to 10.1 as well and we can try to get scarthgap updated to use it

[Jafaral]

@Mergifyio backport stable/10.1

[mergify]

backport stable/10.1

✅ Backports have been created

• #16642 Mimic GNU basename() API for non-glibc library e.g. musl (backport #15561) has been created for branch stable/10.1

[Jafaral]

@kraj backport merged to stable/10.1