Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pimd: MSDP peer MD5 authentication #12459

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

rzalamena
Copy link
Member

This is a refresh of PR #8980 .

Technical Details

MSDP peers that are already connected will not be disconnected when authentication is configured or removed instead you must either:

  • Wait it to disconnect or
  • Manually call the operational command clear ip msdp peer A.B.C.D to apply it immediately

@rzalamena
Copy link
Member Author

frrbot is complaining about some DEFUNs formatting which I won't change.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Dec 7, 2022

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.8737/frr-source'
pimd/pim_msdp_socket.c: In function 'pim_msdp_sock_listen':
pimd/pim_msdp_socket.c:352:36: error: 'sin' undeclared (first use in this function)
pimd/pim_msdp_socket.c:352:36: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:13129: pimd/pimd-pim_msdp_socket.o] Error 1
/usr/home/ci/cibuild.8737/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/usr/home/ci/cibuild.8737/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/usr/home/ci/cibuild.8737/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd
/usr/home/ci/cibuild.8737/frr-source/doc/user/isisd.rst:67: WARNING: duplicate clicmd description of log-adjacency-changes, other instance in fabricd
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:32,
pimd/pim_msdp_socket.c: In function pim_msdp_sock_auth_accept:
./lib/zlog.h:120:20: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 3 has type struct sockaddr_in * [-Werror=format=]
./lib/zlog.h:130:2: note: in expansion of macro _zlog_ecref
pimd/pim_msdp_socket.c:188:4: note: in expansion of macro flog_err
./lib/zlog.h:120:20: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 3 has type struct sockaddr_in * [-Werror=format=]
./lib/zlog.h:130:2: note: in expansion of macro _zlog_ecref
pimd/pim_msdp_socket.c:205:4: note: in expansion of macro flog_err
cc1: all warnings being treated as errors

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/DEB11AMD64/config.status/config.status

NetBSD 9 amd64 build: Failed (click for details) NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/CI012BUILD/config.status/config.status

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.8737/frr-source'
pimd/pim_msdp_socket.c: In function 'pim_msdp_sock_listen':
pimd/pim_msdp_socket.c:352:36: error: 'sin' undeclared (first use in this function)
pimd/pim_msdp_socket.c:352:36: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:13130: pimd/pimd-pim_msdp_socket.o] Error 1
/home/ci/cibuild.8737/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.8737/frr-source/doc/user/nexthop_groups.rst
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:17774: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.

NetBSD 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/CI012BUILD/config.log/config.log.gz

FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.8737/frr-source'
pimd/pim_msdp_socket.c: In function 'pim_msdp_sock_listen':
pimd/pim_msdp_socket.c:352:36: error: 'sin' undeclared (first use in this function)
pimd/pim_msdp_socket.c:352:36: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:13126: pimd/pimd-pim_msdp_socket.o] Error 1
/usr/home/ci/cibuild.8737/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.8737/frr-source/doc/user/nexthop_groups.rst
gmake[1]: Leaving directory '/usr/home/ci/cibuild.8737/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6241: all] Error 2
Successful on other platforms/tests
  • Fedora 29 amd64 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 18.04 arm8 build
  • Debian 9 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Redhat 9 amd64 build
  • Debian 10 amd64 build
  • Ubuntu 22.04 amd64 build
  • Ubuntu 16.04 arm7 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 16.04 amd64 build
  • Ubuntu 18.04 arm7 build
  • CentOS 7 amd64 build
  • Ubuntu 16.04 arm8 build
  • Redhat 8 amd64 build
  • OpenBSD 7 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.8737/frr-source'
pimd/pim_msdp_socket.c: In function 'pim_msdp_sock_listen':
pimd/pim_msdp_socket.c:352:36: error: 'sin' undeclared (first use in this function)
pimd/pim_msdp_socket.c:352:36: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:13129: pimd/pimd-pim_msdp_socket.o] Error 1
/usr/home/ci/cibuild.8737/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/usr/home/ci/cibuild.8737/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/usr/home/ci/cibuild.8737/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd
/usr/home/ci/cibuild.8737/frr-source/doc/user/isisd.rst:67: WARNING: duplicate clicmd description of log-adjacency-changes, other instance in fabricd
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:32,
pimd/pim_msdp_socket.c: In function pim_msdp_sock_auth_accept:
./lib/zlog.h:120:20: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 3 has type struct sockaddr_in * [-Werror=format=]
./lib/zlog.h:130:2: note: in expansion of macro _zlog_ecref
pimd/pim_msdp_socket.c:188:4: note: in expansion of macro flog_err
./lib/zlog.h:120:20: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 3 has type struct sockaddr_in * [-Werror=format=]
./lib/zlog.h:130:2: note: in expansion of macro _zlog_ecref
pimd/pim_msdp_socket.c:205:4: note: in expansion of macro flog_err
cc1: all warnings being treated as errors

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/DEB11AMD64/config.status/config.status

NetBSD 9 amd64 build: Failed (click for details) NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/CI012BUILD/config.status/config.status

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.8737/frr-source'
pimd/pim_msdp_socket.c: In function 'pim_msdp_sock_listen':
pimd/pim_msdp_socket.c:352:36: error: 'sin' undeclared (first use in this function)
pimd/pim_msdp_socket.c:352:36: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:13130: pimd/pimd-pim_msdp_socket.o] Error 1
/home/ci/cibuild.8737/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.8737/frr-source/doc/user/nexthop_groups.rst
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:17774: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.

NetBSD 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/CI012BUILD/config.log/config.log.gz

FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8737/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.8737/frr-source'
pimd/pim_msdp_socket.c: In function 'pim_msdp_sock_listen':
pimd/pim_msdp_socket.c:352:36: error: 'sin' undeclared (first use in this function)
pimd/pim_msdp_socket.c:352:36: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:13126: pimd/pimd-pim_msdp_socket.o] Error 1
/usr/home/ci/cibuild.8737/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.8737/frr-source/doc/user/nexthop_groups.rst
gmake[1]: Leaving directory '/usr/home/ci/cibuild.8737/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
gmake: *** [Makefile:6241: all] Error 2
Report for pim_msdp_socket.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #217: FILE: /tmp/f1-2933373/pim_msdp_socket.c:217:
Report for pim_nb.c | 10 issues
===============================================
< WARNING: line over 80 characters
< #182: FILE: /tmp/f1-2933373/pim_nb.c:182:
< WARNING: line over 80 characters
< #186: FILE: /tmp/f1-2933373/pim_nb.c:186:
< WARNING: line over 80 characters
< #188: FILE: /tmp/f1-2933373/pim_nb.c:188:
< WARNING: line over 80 characters
< #189: FILE: /tmp/f1-2933373/pim_nb.c:189:
< WARNING: line over 80 characters
< #193: FILE: /tmp/f1-2933373/pim_nb.c:193:
Report for pim_nb_config.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #1222: FILE: /tmp/f1-2933373/pim_nb_config.c:1222:
< WARNING: line over 80 characters
< #1276: FILE: /tmp/f1-2933373/pim_nb_config.c:1276:

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Dec 7, 2022

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.8738/frr-source'
pimd/pim_msdp_socket.c: In function 'pim_msdp_sock_listen':
pimd/pim_msdp_socket.c:352:36: error: 'sin' undeclared (first use in this function)
pimd/pim_msdp_socket.c:352:36: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:13129: pimd/pimd-pim_msdp_socket.o] Error 1
/usr/home/ci/cibuild.8738/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/usr/home/ci/cibuild.8738/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/usr/home/ci/cibuild.8738/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd
/usr/home/ci/cibuild.8738/frr-source/doc/user/isisd.rst:67: WARNING: duplicate clicmd description of log-adjacency-changes, other instance in fabricd
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:32,
pimd/pim_msdp_socket.c: In function pim_msdp_sock_auth_accept:
./lib/zlog.h:120:20: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 3 has type struct sockaddr_in * [-Werror=format=]
./lib/zlog.h:130:2: note: in expansion of macro _zlog_ecref
pimd/pim_msdp_socket.c:205:4: note: in expansion of macro flog_err
cc1: all warnings being treated as errors
make[1]: *** [Makefile:13130: pimd/pimd-pim_msdp_socket.o] Error 1
/home/ci/cibuild.8738/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/home/ci/cibuild.8738/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/DEB11AMD64/config.status/config.status

NetBSD 9 amd64 build: Failed (click for details) NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/CI012BUILD/config.status/config.status

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.8738/frr-source'
pimd/pim_msdp_socket.c: In function 'pim_msdp_sock_listen':
pimd/pim_msdp_socket.c:352:36: error: 'sin' undeclared (first use in this function)
pimd/pim_msdp_socket.c:352:36: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:13130: pimd/pimd-pim_msdp_socket.o] Error 1
/home/ci/cibuild.8738/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.8738/frr-source/doc/user/nexthop_groups.rst
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:17774: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.

NetBSD 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/CI012BUILD/config.log/config.log.gz

FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.8738/frr-source'
pimd/pim_msdp_socket.c: In function 'pim_msdp_sock_listen':
pimd/pim_msdp_socket.c:352:36: error: 'sin' undeclared (first use in this function)
pimd/pim_msdp_socket.c:352:36: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:13126: pimd/pimd-pim_msdp_socket.o] Error 1
/usr/home/ci/cibuild.8738/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.8738/frr-source/doc/user/nexthop_groups.rst
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/usr/home/ci/cibuild.8738/frr-source'
gmake: *** [Makefile:6241: all] Error 2
Successful on other platforms/tests
  • Fedora 29 amd64 build
  • Ubuntu 20.04 amd64 build
  • OpenBSD 7 amd64 build
  • Ubuntu 18.04 arm8 build
  • Debian 9 amd64 build
  • Redhat 8 amd64 build
  • Redhat 9 amd64 build
  • Debian 10 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Ubuntu 16.04 arm7 build
  • Ubuntu 22.04 amd64 build
  • Ubuntu 16.04 arm8 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 16.04 amd64 build
  • CentOS 7 amd64 build
  • Ubuntu 16.04 i386 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.8738/frr-source'
pimd/pim_msdp_socket.c: In function 'pim_msdp_sock_listen':
pimd/pim_msdp_socket.c:352:36: error: 'sin' undeclared (first use in this function)
pimd/pim_msdp_socket.c:352:36: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:13129: pimd/pimd-pim_msdp_socket.o] Error 1
/usr/home/ci/cibuild.8738/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/usr/home/ci/cibuild.8738/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd
/usr/home/ci/cibuild.8738/frr-source/doc/user/isisd.rst:58: WARNING: duplicate clicmd description of attached-bit [receive ignore | send], other instance in fabricd
/usr/home/ci/cibuild.8738/frr-source/doc/user/isisd.rst:67: WARNING: duplicate clicmd description of log-adjacency-changes, other instance in fabricd
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:32,
pimd/pim_msdp_socket.c: In function pim_msdp_sock_auth_accept:
./lib/zlog.h:120:20: error: format %pI4 expects argument of type in_addr_t {aka unsigned int} *, but argument 3 has type struct sockaddr_in * [-Werror=format=]
./lib/zlog.h:130:2: note: in expansion of macro _zlog_ecref
pimd/pim_msdp_socket.c:205:4: note: in expansion of macro flog_err
cc1: all warnings being treated as errors
make[1]: *** [Makefile:13130: pimd/pimd-pim_msdp_socket.o] Error 1
/home/ci/cibuild.8738/frr-source/doc/user/isisd.rst:43: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd
/home/ci/cibuild.8738/frr-source/doc/user/isisd.rst:53: WARNING: duplicate clicmd description of domain-password [clear | md5] <password>, other instance in fabricd

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/DEB11AMD64/config.status/config.status

NetBSD 9 amd64 build: Failed (click for details) NetBSD 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/CI012BUILD/config.status/config.status

Make failed for NetBSD 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/CI012BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.8738/frr-source'
pimd/pim_msdp_socket.c: In function 'pim_msdp_sock_listen':
pimd/pim_msdp_socket.c:352:36: error: 'sin' undeclared (first use in this function)
pimd/pim_msdp_socket.c:352:36: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:13130: pimd/pimd-pim_msdp_socket.o] Error 1
/home/ci/cibuild.8738/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.8738/frr-source/doc/user/nexthop_groups.rst
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:17774: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.

NetBSD 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/CI012BUILD/config.log/config.log.gz

FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-8738/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.8738/frr-source'
pimd/pim_msdp_socket.c: In function 'pim_msdp_sock_listen':
pimd/pim_msdp_socket.c:352:36: error: 'sin' undeclared (first use in this function)
pimd/pim_msdp_socket.c:352:36: note: each undeclared identifier is reported only once for each function it appears in
gmake[1]: *** [Makefile:13126: pimd/pimd-pim_msdp_socket.o] Error 1
/usr/home/ci/cibuild.8738/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.8738/frr-source/doc/user/nexthop_groups.rst
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/usr/home/ci/cibuild.8738/frr-source'
gmake: *** [Makefile:6241: all] Error 2
Report for pim_msdp_socket.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #217: FILE: /tmp/f1-2949090/pim_msdp_socket.c:217:
Report for pim_nb.c | 10 issues
===============================================
< WARNING: line over 80 characters
< #182: FILE: /tmp/f1-2949090/pim_nb.c:182:
< WARNING: line over 80 characters
< #186: FILE: /tmp/f1-2949090/pim_nb.c:186:
< WARNING: line over 80 characters
< #188: FILE: /tmp/f1-2949090/pim_nb.c:188:
< WARNING: line over 80 characters
< #189: FILE: /tmp/f1-2949090/pim_nb.c:189:
< WARNING: line over 80 characters
< #193: FILE: /tmp/f1-2949090/pim_nb.c:193:
Report for pim_nb_config.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #1222: FILE: /tmp/f1-2949090/pim_nb_config.c:1222:
< WARNING: line over 80 characters
< #1276: FILE: /tmp/f1-2949090/pim_nb_config.c:1276:

@rzalamena
Copy link
Member Author

Force pushed rebased changes:

  • Fixed BSD compilation
  • zlog_* warning/error

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Dec 7, 2022

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8741/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for pim_msdp_socket.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #217: FILE: /tmp/f1-3571835/pim_msdp_socket.c:217:
Report for pim_nb.c | 10 issues
===============================================
< WARNING: line over 80 characters
< #182: FILE: /tmp/f1-3571835/pim_nb.c:182:
< WARNING: line over 80 characters
< #186: FILE: /tmp/f1-3571835/pim_nb.c:186:
< WARNING: line over 80 characters
< #188: FILE: /tmp/f1-3571835/pim_nb.c:188:
< WARNING: line over 80 characters
< #189: FILE: /tmp/f1-3571835/pim_nb.c:189:
< WARNING: line over 80 characters
< #193: FILE: /tmp/f1-3571835/pim_nb.c:193:
Report for pim_nb_config.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #1222: FILE: /tmp/f1-3571835/pim_nb_config.c:1222:
< WARNING: line over 80 characters
< #1276: FILE: /tmp/f1-3571835/pim_nb_config.c:1276:

@rzalamena
Copy link
Member Author

Rebased on top of latest master.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 14, 2023

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/REDHAT8/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9667/frr-source/doc/user/nexthop_groups.rst
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^~~~~~~~~~
pimd/pim6_mld.c: In function gm_handle_v2_pass1:

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/REDHAT8/config.log/config.log.gz

Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/F29BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9667/frr-source/doc/user/nexthop_groups.rst
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^~~~~~~~~~
pimd/pim6_mld.c: In function gm_handle_v2_pass1:
Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

pimd/pim6_mld.c:1015:4: note: #pragma message: need S,G PRUNE => NO_INFO transition here
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: all warnings being treated as errors
Makefile:12327: recipe for target 'pimd/pimd_pimd-pim_cmd.o' failed
make[1]: *** [pimd/pimd_pimd-pim_cmd.o] Error 1
make[1]: Target 'all-am' not remade because of errors.

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U18ARM8BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/DEB10BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9667/frr-source/doc/user/nexthop_groups.rst
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^~~~~~~~~~
pimd/pim6_mld.c: In function gm_handle_v2_pass1:

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/DEB10BUILD/config.log/config.log.gz

Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^~~~~~~~~~
pimd/pim6_mld.c: In function gm_handle_v2_pass1:
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9667/frr-source/doc/user/nexthop_groups.rst
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
 4833 |  return nb_cli_apply_changes(vty, xpath);
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
 4866 |  return nb_cli_apply_changes(vty, xpath);
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
pimd/pim6_mld.c: In function gm_handle_v2_pass1:

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9667/frr-source/doc/user/nexthop_groups.rst
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^~~~~~~~~~
pimd/pim6_mld.c: In function gm_handle_v2_pass1:
Redhat 9 amd64 build: Failed (click for details) Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/RH9BUILD/ErrorLog/log_make.txt)

doc/user/_build/texinfo/frr.texi:27293: warning: could not find @image file `frr-figures/pathd_initiated_multi.txt' nor alternate text
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:42: error: format not a string literal and no format arguments [-Werror=format-security]
 4833 |         return nb_cli_apply_changes(vty, xpath);
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:42: error: format not a string literal and no format arguments [-Werror=format-security]
 4866 |         return nb_cli_apply_changes(vty, xpath);
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
pimd/pim6_mld.c: In function gm_handle_v2_pass1:

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/RH9BUILD/config.log/config.log.gz

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^
pimd/pim6_mld.c: In function gm_handle_v2_pass1:

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI101BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.9667/frr-source/doc/user/zebra.rst:797: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
pimd/pim_cmd.c: In function 'ip_msdp_peer_md5_magic':
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
 4833 |  return nb_cli_apply_changes(vty, xpath);
pimd/pim_cmd.c: In function 'no_ip_msdp_peer_md5_magic':
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
 4866 |  return nb_cli_apply_changes(vty, xpath);
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:12998: pimd/pimd-pim_cmd.o] Error 1
Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/zebra.rst:797: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:42: error: format not a string literal and no format arguments [-Werror=format-security]
 4833 |         return nb_cli_apply_changes(vty, xpath);
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:42: error: format not a string literal and no format arguments [-Werror=format-security]
 4866 |         return nb_cli_apply_changes(vty, xpath);
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
pimd/pim6_mld.c: In function gm_handle_v2_pass1:

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U22AMD64BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U1804AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9667/frr-source/doc/user/nexthop_groups.rst
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^~~~~~~~~~
pimd/pim6_mld.c: In function gm_handle_v2_pass1:
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

pimd/pim6_mld.c:1015:4: note: #pragma message: need S,G PRUNE => NO_INFO transition here
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: all warnings being treated as errors
Makefile:12327: recipe for target 'pimd/pimd_pimd-pim_cmd.o' failed
make[1]: *** [pimd/pimd_pimd-pim_cmd.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^
pimd/pim6_mld.c: In function gm_handle_v2_pass1:
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U18I386BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9667/frr-source/doc/user/nexthop_groups.rst
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^~~~~~~~~~
pimd/pim6_mld.c: In function gm_handle_v2_pass1:

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

pimd/pim6_mld.c:1015:4: note: #pragma message: need S,G PRUNE => NO_INFO transition here
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: all warnings being treated as errors
Makefile:12327: recipe for target 'pimd/pimd_pimd-pim_cmd.o' failed
make[1]: *** [pimd/pimd_pimd-pim_cmd.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/DEB11AMD64/ErrorLog/log_make.txt)

doc/user/_build/texinfo/frr.texi:27293: warning: could not find @image file `frr-figures/pathd_initiated_multi.txt' nor alternate text
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
 4833 |  return nb_cli_apply_changes(vty, xpath);
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
 4866 |  return nb_cli_apply_changes(vty, xpath);
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
pimd/pim6_mld.c: In function gm_handle_v2_pass1:

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/DEB11AMD64/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^
pimd/pim6_mld.c: In function gm_handle_v2_pass1:
FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.9667/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.9667/frr-source/doc/user/nexthop_groups.rst
pimd/pim_cmd.c: In function 'ip_msdp_peer_md5_magic':
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function 'no_ip_msdp_peer_md5_magic':
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:12995: pimd/pimd-pim_cmd.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.9667/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
Successful on other platforms/tests
  • OpenBSD 7 amd64 build
  • CentOS 7 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Redhat 8 amd64 build: Failed (click for details) Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/REDHAT8/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9667/frr-source/doc/user/nexthop_groups.rst
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^~~~~~~~~~
pimd/pim6_mld.c: In function gm_handle_v2_pass1:

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/REDHAT8/config.log/config.log.gz

Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/F29BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9667/frr-source/doc/user/nexthop_groups.rst
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^~~~~~~~~~
pimd/pim6_mld.c: In function gm_handle_v2_pass1:
Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

pimd/pim6_mld.c:1015:4: note: #pragma message: need S,G PRUNE => NO_INFO transition here
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: all warnings being treated as errors
Makefile:12327: recipe for target 'pimd/pimd_pimd-pim_cmd.o' failed
make[1]: *** [pimd/pimd_pimd-pim_cmd.o] Error 1
make[1]: Target 'all-am' not remade because of errors.

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U18ARM8BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/DEB10BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9667/frr-source/doc/user/nexthop_groups.rst
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^~~~~~~~~~
pimd/pim6_mld.c: In function gm_handle_v2_pass1:

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/DEB10BUILD/config.log/config.log.gz

Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^~~~~~~~~~
pimd/pim6_mld.c: In function gm_handle_v2_pass1:
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9667/frr-source/doc/user/nexthop_groups.rst
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
 4833 |  return nb_cli_apply_changes(vty, xpath);
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
 4866 |  return nb_cli_apply_changes(vty, xpath);
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
pimd/pim6_mld.c: In function gm_handle_v2_pass1:

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9667/frr-source/doc/user/nexthop_groups.rst
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^~~~~~~~~~
pimd/pim6_mld.c: In function gm_handle_v2_pass1:
Redhat 9 amd64 build: Failed (click for details) Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/RH9BUILD/ErrorLog/log_make.txt)

doc/user/_build/texinfo/frr.texi:27293: warning: could not find @image file `frr-figures/pathd_initiated_multi.txt' nor alternate text
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:42: error: format not a string literal and no format arguments [-Werror=format-security]
 4833 |         return nb_cli_apply_changes(vty, xpath);
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:42: error: format not a string literal and no format arguments [-Werror=format-security]
 4866 |         return nb_cli_apply_changes(vty, xpath);
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
pimd/pim6_mld.c: In function gm_handle_v2_pass1:

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/RH9BUILD/config.log/config.log.gz

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^
pimd/pim6_mld.c: In function gm_handle_v2_pass1:

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI101BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.9667/frr-source/doc/user/zebra.rst:797: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
pimd/pim_cmd.c: In function 'ip_msdp_peer_md5_magic':
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
 4833 |  return nb_cli_apply_changes(vty, xpath);
pimd/pim_cmd.c: In function 'no_ip_msdp_peer_md5_magic':
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
 4866 |  return nb_cli_apply_changes(vty, xpath);
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:12998: pimd/pimd-pim_cmd.o] Error 1
Ubuntu 22.04 amd64 build: Failed (click for details) Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/zebra.rst:797: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:42: error: format not a string literal and no format arguments [-Werror=format-security]
 4833 |         return nb_cli_apply_changes(vty, xpath);
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:42: error: format not a string literal and no format arguments [-Werror=format-security]
 4866 |         return nb_cli_apply_changes(vty, xpath);
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
pimd/pim6_mld.c: In function gm_handle_v2_pass1:

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U22AMD64BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U1804AMD64/config.log/config.log.gz Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U1804AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9667/frr-source/doc/user/nexthop_groups.rst
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^~~~~~~~~~
pimd/pim6_mld.c: In function gm_handle_v2_pass1:
Ubuntu 16.04 arm8 build: Failed (click for details) Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U16ARM8BUILD/config.status/config.status Ubuntu 16.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U16ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

pimd/pim6_mld.c:1015:4: note: #pragma message: need S,G PRUNE => NO_INFO transition here
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: all warnings being treated as errors
Makefile:12327: recipe for target 'pimd/pimd_pimd-pim_cmd.o' failed
make[1]: *** [pimd/pimd_pimd-pim_cmd.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI014BUILD/config.log/config.log.gz Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^
pimd/pim6_mld.c: In function gm_handle_v2_pass1:
Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U18I386BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.9667/frr-source/doc/user/nexthop_groups.rst
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^~~~~~~~~~
pimd/pim6_mld.c: In function gm_handle_v2_pass1:

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U18I386BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details) Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

pimd/pim6_mld.c:1015:4: note: #pragma message: need S,G PRUNE => NO_INFO transition here
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: all warnings being treated as errors
Makefile:12327: recipe for target 'pimd/pimd_pimd-pim_cmd.o' failed
make[1]: *** [pimd/pimd_pimd-pim_cmd.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/DEB11AMD64/ErrorLog/log_make.txt)

doc/user/_build/texinfo/frr.texi:27293: warning: could not find @image file `frr-figures/pathd_initiated_multi.txt' nor alternate text
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
 4833 |  return nb_cli_apply_changes(vty, xpath);
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
 4866 |  return nb_cli_apply_changes(vty, xpath);
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
pimd/pim6_mld.c: In function gm_handle_v2_pass1:

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/DEB11AMD64/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.9667/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
pimd/pim_cmd.c: In function ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function no_ip_msdp_peer_md5_magic:
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim6_mld.c:362:1: note: #pragma message: TODO: S,G entries in EXCLUDE (i.e. prune) unsupported
 CPP_NOTICE("TODO: S,G entries in EXCLUDE (i.e. prune) unsupported");
 ^
pimd/pim6_mld.c: In function gm_handle_v2_pass1:
FreeBSD 12 amd64 build: Failed (click for details) FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-9667/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.9667/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.9667/frr-source/doc/user/nexthop_groups.rst
pimd/pim_cmd.c: In function 'ip_msdp_peer_md5_magic':
pimd/pim_cmd.c:4833:35: error: format not a string literal and no format arguments [-Werror=format-security]
pimd/pim_cmd.c: In function 'no_ip_msdp_peer_md5_magic':
pimd/pim_cmd.c:4866:35: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:12995: pimd/pimd-pim_cmd.o] Error 1
gmake[1]: Leaving directory '/usr/home/ci/cibuild.9667/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.
Report for pim_msdp_socket.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #217: FILE: /tmp/f1-1204342/pim_msdp_socket.c:217:
Report for pim_nb.c | 10 issues
===============================================
< WARNING: line over 80 characters
< #182: FILE: /tmp/f1-1204342/pim_nb.c:182:
< WARNING: line over 80 characters
< #186: FILE: /tmp/f1-1204342/pim_nb.c:186:
< WARNING: line over 80 characters
< #188: FILE: /tmp/f1-1204342/pim_nb.c:188:
< WARNING: line over 80 characters
< #189: FILE: /tmp/f1-1204342/pim_nb.c:189:
< WARNING: line over 80 characters
< #193: FILE: /tmp/f1-1204342/pim_nb.c:193:
Report for pim_nb_config.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #1222: FILE: /tmp/f1-1204342/pim_nb_config.c:1222:
< WARNING: line over 80 characters
< #1276: FILE: /tmp/f1-1204342/pim_nb_config.c:1276:

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Feb 15, 2023

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-9719/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for pim_msdp_socket.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #217: FILE: /tmp/f1-75248/pim_msdp_socket.c:217:
Report for pim_nb.c | 10 issues
===============================================
< WARNING: line over 80 characters
< #182: FILE: /tmp/f1-75248/pim_nb.c:182:
< WARNING: line over 80 characters
< #186: FILE: /tmp/f1-75248/pim_nb.c:186:
< WARNING: line over 80 characters
< #188: FILE: /tmp/f1-75248/pim_nb.c:188:
< WARNING: line over 80 characters
< #189: FILE: /tmp/f1-75248/pim_nb.c:189:
< WARNING: line over 80 characters
< #193: FILE: /tmp/f1-75248/pim_nb.c:193:
Report for pim_nb_config.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #1222: FILE: /tmp/f1-75248/pim_nb_config.c:1222:
< WARNING: line over 80 characters
< #1276: FILE: /tmp/f1-75248/pim_nb_config.c:1276:

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14310/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14310/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log found
Successful on other platforms/tests
  • Topotests Ubuntu 18.04 i386 part 7
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 9
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 amd64 part 2
  • Debian 10 deb pkg check
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 amd64 part 0
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 amd64 part 5
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 7
  • Addresssanitizer topotests part 3
  • Addresssanitizer topotests part 9
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 arm8 part 5
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 i386 part 9
  • Addresssanitizer topotests part 6
  • Topotests debian 10 amd64 part 1
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 8
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 6
  • Ubuntu 18.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 1
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests debian 10 amd64 part 6
  • Addresssanitizer topotests part 4
  • Debian 9 deb pkg check
  • Topotests debian 10 amd64 part 5
  • Addresssanitizer topotests part 8

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-14310/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log found
Report for pim_msdp_socket.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #204: FILE: /tmp/f1-3548913/pim_msdp_socket.c:204:

@rzalamena rzalamena force-pushed the msdp-auth-v2 branch 3 times, most recently from 58df67e to 6fef467 Compare July 17, 2024 02:27
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Specify MSDP authentication specification model.

Signed-off-by: Rafael Zalamena <[email protected]>
Implement MSDP MD5 authentication connection support.

Implementation details:
- Move the MSDP socket creation code to a generic function so it can be
  parametrized to be used with/without authentication.
- The MSDP peer connection will not change when the configuration is
  set, instead it will only be applied next connection or when
  `clear ip msdp peer A.B.C.D` is called.

Signed-off-by: Rafael Zalamena <[email protected]>
Tell user how to use the new authentication and clear commands.

Signed-off-by: Rafael Zalamena <[email protected]>
Add definition of `TCP_MD5SIG_MAXKEYLEN` in the `sockopt.h` header so
users of it have the definition of the maximum key length for socket
authentication operations.

The following OSes reported failure in CI while building:
 - NetBSD 8
 - FreeBSD 11
 - FreeBSD 12

Signed-off-by: Rafael Zalamena <[email protected]>
Modify existing MSDP topology to use authentication.

Signed-off-by: Rafael Zalamena <[email protected]>
@donaldsharp donaldsharp merged commit b8747d8 into FRRouting:master Jul 30, 2024
11 checks passed
@rzalamena rzalamena deleted the msdp-auth-v2 branch July 30, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants