Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: no neighbor X enforce-first-as does not work with peer-groups #17702

Closed
2 tasks done
f0o opened this issue Dec 21, 2024 · 1 comment
Closed
2 tasks done

bgpd: no neighbor X enforce-first-as does not work with peer-groups #17702

f0o opened this issue Dec 21, 2024 · 1 comment
Assignees
@ton31337
Labels
bgp bug

Comments

@f0o
Copy link

f0o commented Dec 21, 2024

Description

when using no neighbor x enforce-first-as with a peer-group the command is accepted but it has no effect.

Version

10.0.1-0~ubuntu22.04.1

How to reproduce

  1. Create peer-group TEST
  2. enter no neigh TEST enforce-first-as
  3. Add neighbors to peer-group
  4. See no routes received as 2. has no effect

Expected behavior

it should be synonymous with no neigh 1.2.3.4 enforce-first-as

Actual behavior

no effect, no error, config written fine

Additional context

No response

Checklist

  • I have searched the open issues for this bug.
  • I have not included sensitive information in this report.
@f0o f0o added the triage Needs further investigation label Dec 21, 2024
@ton31337 ton31337 added the bgp label Dec 21, 2024
@ton31337 ton31337 self-assigned this Dec 21, 2024
@ton31337
Copy link
Member

Could you try compiling this PR #17705?

@ton31337 ton31337 added bug and removed triage Needs further investigation labels Dec 21, 2024
mergify bot pushed a commit that referenced this issue Dec 22, 2024
@ton31337 @mergify
bgpd: Fix enforce-first-as per peer-group removal
e04056e 
If we do `no neighbor PG enforce-first-as`, it wasn't working because the flag
was inherited incorrectly for the members of the peer-group.

Fixes: 3224629 ("bgpd: Enable enforce-first-as by default")

Closes: #17702

Signed-off-by: Donatas Abraitis <[email protected]>
(cherry picked from commit b6dcf61)
mergify bot pushed a commit that referenced this issue Dec 22, 2024
@ton31337 @mergify
bgpd: Fix enforce-first-as per peer-group removal
311199f 
If we do `no neighbor PG enforce-first-as`, it wasn't working because the flag
was inherited incorrectly for the members of the peer-group.

Fixes: 3224629 ("bgpd: Enable enforce-first-as by default")

Closes: #17702

Signed-off-by: Donatas Abraitis <[email protected]>
(cherry picked from commit b6dcf61)
mergify bot pushed a commit that referenced this issue Dec 22, 2024
@ton31337 @mergify
bgpd: Fix enforce-first-as per peer-group removal
46d2d76 
If we do `no neighbor PG enforce-first-as`, it wasn't working because the flag
was inherited incorrectly for the members of the peer-group.

Fixes: 3224629 ("bgpd: Enable enforce-first-as by default")

Closes: #17702

Signed-off-by: Donatas Abraitis <[email protected]>
(cherry picked from commit b6dcf61)
ton31337 added a commit to opensourcerouting/frr that referenced this issue Dec 22, 2024
@ton31337
bgpd: Fix enforce-first-as per peer-group removal
d893a04 
If we do `no neighbor PG enforce-first-as`, it wasn't working because the flag
was inherited incorrectly for the members of the peer-group.

Fixes: 3224629 ("bgpd: Enable enforce-first-as by default")

Closes: FRRouting#17702

Signed-off-by: Donatas Abraitis <[email protected]>
ton31337 added a commit to opensourcerouting/frr that referenced this issue Dec 22, 2024
@ton31337
bgpd: Fix enforce-first-as per peer-group removal
8a1737d 
If we do `no neighbor PG enforce-first-as`, it wasn't working because the flag
was inherited incorrectly for the members of the peer-group.

Fixes: 3224629 ("bgpd: Enable enforce-first-as by default")

Closes: FRRouting#17702

Signed-off-by: Donatas Abraitis <[email protected]>
ton31337 added a commit to opensourcerouting/frr that referenced this issue Dec 22, 2024
@ton31337
bgpd: Fix enforce-first-as per peer-group removal
327d08b 
If we do `no neighbor PG enforce-first-as`, it wasn't working because the flag
was inherited incorrectly for the members of the peer-group.

Fixes: 3224629 ("bgpd: Enable enforce-first-as by default")

Closes: FRRouting#17702

Signed-off-by: Donatas Abraitis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ton31337 ton31337

Labels
bgp bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@f0o @ton31337