Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ripd: can not deleted distribute-list via "mgmt delete-config" #16538

Closed
ak503 opened this issue Aug 8, 2024 · 0 comments · Fixed by #16551
Closed

ripd: can not deleted distribute-list via "mgmt delete-config" #16538

ak503 opened this issue Aug 8, 2024 · 0 comments · Fixed by #16551

Comments

@ak503
Copy link
Contributor

ak503 commented Aug 8, 2024

latest frr-master.

Configure filter:

vtysh -c "c t" -c "access-list ACL33 seq 10 permit 3.3.3.0/24"
vtysh -c "c t" -c  "router rip" -c "distribute-list ACL33 in enp0s3"

vtysh -c "show mgmt get-config running /"
[
  "/frr-filter:lib/access-list[type='ipv4'][name='ACL33']/type": "ipv4"
  "/frr-filter:lib/access-list[type='ipv4'][name='ACL33']/name": "ACL33"
  "/frr-filter:lib/access-list[type='ipv4'][name='ACL33']/entry[sequence='10']/sequence": "10"
  "/frr-filter:lib/access-list[type='ipv4'][name='ACL33']/entry[sequence='10']/action": "permit"
  "/frr-filter:lib/access-list[type='ipv4'][name='ACL33']/entry[sequence='10']/ipv4-prefix": "3.3.3.0/24"
  "/frr-filter:lib/access-list[type='ipv4'][name='ACL33']/entry[sequence='10']/ipv4-exact-match": "false"
  "/frr-ripd:ripd/instance[vrf='default']/vrf": "default"
  "/frr-ripd:ripd/instance[vrf='default']/allow-ecmp": "0"
  "/frr-ripd:ripd/instance[vrf='default']/default-information-originate": "false"
  "/frr-ripd:ripd/instance[vrf='default']/default-metric": "1"
  "/frr-ripd:ripd/instance[vrf='default']/distance/default": "0"
  "/frr-ripd:ripd/instance[vrf='default']/passive-default": "false"
  "/frr-ripd:ripd/instance[vrf='default']/distribute-list[interface='enp0s3']/interface": "enp0s3"
  "/frr-ripd:ripd/instance[vrf='default']/distribute-list[interface='enp0s3']/in/access-list": "ACL33"
  "/frr-ripd:ripd/instance[vrf='default']/timers/flush-interval": "120"
  "/frr-ripd:ripd/instance[vrf='default']/timers/holddown-interval": "180"
  "/frr-ripd:ripd/instance[vrf='default']/timers/update-interval": "30"
  "/frr-ripd:ripd/instance[vrf='default']/version/receive": "1-2"
  "/frr-ripd:ripd/instance[vrf='default']/version/send": "2"
  "/frr-zebra:zebra/mcast-rpf-lookup": "mrib-then-urib"
  "/frr-zebra:zebra/workqueue-hold-timer": "10"
  "/frr-zebra:zebra/zapi-packets": "1000"
  "/frr-zebra:zebra/import-kernel-table/distance": "15"
  "/frr-zebra:zebra/dplane-queue-limit": "200"
  "/frr-zebra:zebra/route-map-delay": "5"
]
vtysh -c "show ip rip status" 
Routing Protocol is "rip"
  Sending updates every 30 seconds with +/-50%, next due in 12 seconds
  Timeout after 180 seconds, garbage collect after 120 seconds
  Outgoing update filter list for all interface is not set
    enp0s3 filtered by nothing
  Incoming update filter list for all interface is not set
    enp0s3 filtered by ACL33

Delete filter:

vtysh -c "c t f" -c "mgmt delete-config /frr-ripd:ripd/instance[vrf='default']/distribute-list[interface='enp0s3']" -c "mgmt commit apply"
vtysh -c "show mgmt get-config running /"
[
  "/frr-filter:lib/access-list[type='ipv4'][name='ACL33']/type": "ipv4"
  "/frr-filter:lib/access-list[type='ipv4'][name='ACL33']/name": "ACL33"
  "/frr-filter:lib/access-list[type='ipv4'][name='ACL33']/entry[sequence='10']/sequence": "10"
  "/frr-filter:lib/access-list[type='ipv4'][name='ACL33']/entry[sequence='10']/action": "permit"
  "/frr-filter:lib/access-list[type='ipv4'][name='ACL33']/entry[sequence='10']/ipv4-prefix": "3.3.3.0/24"
  "/frr-filter:lib/access-list[type='ipv4'][name='ACL33']/entry[sequence='10']/ipv4-exact-match": "false"
  "/frr-ripd:ripd/instance[vrf='default']/vrf": "default"
  "/frr-ripd:ripd/instance[vrf='default']/allow-ecmp": "0"
  "/frr-ripd:ripd/instance[vrf='default']/default-information-originate": "false"
  "/frr-ripd:ripd/instance[vrf='default']/default-metric": "1"
  "/frr-ripd:ripd/instance[vrf='default']/distance/default": "0"
  "/frr-ripd:ripd/instance[vrf='default']/passive-default": "false"
  "/frr-ripd:ripd/instance[vrf='default']/timers/flush-interval": "120"
  "/frr-ripd:ripd/instance[vrf='default']/timers/holddown-interval": "180"
  "/frr-ripd:ripd/instance[vrf='default']/timers/update-interval": "30"
  "/frr-ripd:ripd/instance[vrf='default']/version/receive": "1-2"
  "/frr-ripd:ripd/instance[vrf='default']/version/send": "2"
  "/frr-zebra:zebra/mcast-rpf-lookup": "mrib-then-urib"
  "/frr-zebra:zebra/workqueue-hold-timer": "10"
  "/frr-zebra:zebra/zapi-packets": "1000"
  "/frr-zebra:zebra/import-kernel-table/distance": "15"
  "/frr-zebra:zebra/dplane-queue-limit": "200"
  "/frr-zebra:zebra/route-map-delay": "5"
]

no iface filter in config, but filter is work

vtysh -c "show ip rip status" 
Routing Protocol is "rip"
  Sending updates every 30 seconds with +/-50%, next due in 12 seconds
  Timeout after 180 seconds, garbage collect after 120 seconds
  Outgoing update filter list for all interface is not set
    enp0s3 filtered by nothing
  Incoming update filter list for all interface is not set
    enp0s3 filtered by ACL33
mergify bot pushed a commit that referenced this issue Aug 12, 2024
When a whole distribute-list is deleted (can be done only using API),
all its children must be cleaned up manually.

Fixes #16538

Signed-off-by: Igor Ryzhov <[email protected]>
(cherry picked from commit 8fad4f3)
mergify bot pushed a commit that referenced this issue Aug 12, 2024
When a whole distribute-list is deleted (can be done only using API),
all its children must be cleaned up manually.

Fixes #16538

Signed-off-by: Igor Ryzhov <[email protected]>
(cherry picked from commit 8fad4f3)
mergify bot pushed a commit that referenced this issue Aug 12, 2024
When a whole distribute-list is deleted (can be done only using API),
all its children must be cleaned up manually.

Fixes #16538

Signed-off-by: Igor Ryzhov <[email protected]>
(cherry picked from commit 8fad4f3)

# Conflicts:
#	lib/distribute.c
mergify bot pushed a commit that referenced this issue Aug 12, 2024
When a whole distribute-list is deleted (can be done only using API),
all its children must be cleaned up manually.

Fixes #16538

Signed-off-by: Igor Ryzhov <[email protected]>
(cherry picked from commit 8fad4f3)

# Conflicts:
#	lib/distribute.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant