Merge pull request #17683 from FRRouting/mergify/bp/stable/8.5/pr-17675

bgpd: Fix memory leak when creating BMP connection with a source interface (backport #17675)
FRRouting · Dec 20, 2024 · f4d813f · f4d813f
2 parents fb3b95b + 2c3d4a5
commit f4d813f
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/bgpd/bgp_bmp.c b/bgpd/bgp_bmp.c
@@ -2154,8 +2154,11 @@ DEFPY(bmp_connect,
 	}
 
 	ba = bmp_active_get(bt, hostname, port);
-	if (srcif)
+	if (srcif) {
+		if (ba->ifsrc)
+			XFREE(MTYPE_TMP, ba->ifsrc);
 		ba->ifsrc = XSTRDUP(MTYPE_TMP, srcif);
+	}
 	if (min_retry_str)
 		ba->minretry = min_retry;
 	if (max_retry_str)