bgpd: update AS value of a hidden bgp instance

'import vrf CUSTOM' could define a hidden bgp instance with the default AS_UNSPECIFIED (i.e. = 1) value. When a router bgp AS vrf CUSTOM gets configured later on, replace this AS_UNSPECIFIED setting with a requested value. Signed-off-by: Alexander Skorichenko <[email protected]>
FRRouting · Jan 15, 2025 · 91f3e1c · 91f3e1c
1 parent 0bc373c
commit 91f3e1c
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/bgpd/bgpd.c b/bgpd/bgpd.c
@@ -3403,7 +3403,8 @@ static struct bgp *bgp_create(as_t *as, const char *name,
 
 	if (hidden) {
 		bgp = bgp_old;
-		goto peer_init;
+	} else {
+		bgp = XCALLOC(MTYPE_BGP, sizeof(struct bgp));
 	}
 
 	bgp = XCALLOC(MTYPE_BGP, sizeof(struct bgp));
@@ -3413,6 +3414,10 @@ static struct bgp *bgp_create(as_t *as, const char *name,
 	else
 		bgp->as_pretty = XSTRDUP(MTYPE_BGP_NAME, asn_asn2asplain(*as));
 
+	if (hidden) {
+		goto peer_init;
+	}
+
 	if (asnotation != ASNOTATION_UNDEFINED) {
 		bgp->asnotation = asnotation;
 		SET_FLAG(bgp->config, BGP_CONFIG_ASNOTATION);