Start of climber server cleanup - #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kjaget
commented
Mar 26, 2019
kjaget
commented
- add and use method for safer waiting for elevator server to return success (allow it to be preempted)
- reduce delay after firing pins/deploy
nmullane
reviewed
Mar 27, 2019
| { | ||
| bool waiting_for_elevator = true; | ||
| const double start_time = ros::Time::now().toSec(); | ||
| while (waiting_for_elevator) |
There was a problem hiding this comment.
There is currently no max wait time which we probably want, as timed_out is only set once the goal succeeds or preempts
There was a problem hiding this comment.
We should also probably have a ros::ok() check in the while loop
There was a problem hiding this comment.
Yeah, makes sense. Please take another look.
kjaget
force-pushed
the
climber_safer_preempt
branch
from
34a1c14
to
17e4432
Compare
- add and use method for safer waiting for elevator server to return success (allow it to be preempted) - reduce delay after firing pins/deploy
Make elevator_server class member functions protected
kjaget
force-pushed
the
climber_safer_preempt
branch
from
17e4432
to
b6e92ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.