Licensing cleanup #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #55
I have performed some README rewriting to be more respectful to the original holders of code that was adapted or modified, specifically since PromptPlus has used non-trivial amounts of code and even details like general project structure (CONTRIBUTING, README etc.) from other projects.
I have also included their licenses and copyrights with the project, as MIT License dictates.
There is a major licensing issue left I did not address:
FIGlet.Net is a AGPLv3 project, and that license dictates that PromptPlus should also be an AGPLv3 project if it uses AGPLv3 code.
Therefore, you should find an alternative to code from that library, either by writing it yourself of picking a different library, such as the one FIGlet.Net is based on, which is MIT.
I have not made changes in regards to that.
I hope that this is in agreement with licensing wishes from @shibayan, @spectreconsole and @charlesdevandiere.