fixing the automap color values for upper row of LEDs #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Would be fantastic if this got merged, I just made the exact same PR when I encountered this. |
|
Sorry for being a bit late to the party, but I've Which Launchpad are you using? |
|
First and foremost: hope you are recovering and getting well soon. I am using the Launchpad Mini and the problem looks like a simple copy&paste error in the source ;) Stumbled on it while coding https://github.com/mutax/soundpad Florian |
|
Tja, ich - also; äh ... Well, whatever :) Thanks for fixing this! |
|
Passiert den Besten ;p I think this might have been my first pull real request/contribution on github - thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to change colors of the upper row of LEDs I noticed I am only able to turn them on, and only set to yellow, whatever I try.
Attachted patch fixes that behaviour, it seems there have been some copy&paste errors in the automap method.