Tabs managment #976
Open
Tabs managment #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we remove MUI lab? Or is there no alternative in MUI for the things that depend on it? |
|
Should be good now, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrote TabPanel and TabContext using @mui/material as components instead of importing them from @mui/lab
Closes #975
Type of change
Please delete options that are not relevant.
Screenshots
// works as same as usual - no visual change
Checklist
Rewrote components
Update import in each page that use tabs to use the new components
remove the @mui/lab package ( I was sure this was to point of this issue )
Things like LoadingButton from
judging-schedule-editor.tsxstill depend on @mui/lab so we cant yet remove it.