Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Nonce too low error on 2nd contract deploy #74

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

MattWong-ca
Copy link
Collaborator

Description

  • When following README and doing yarn deploy we get a nonce too low error due to the sequential contract deployments. Adding a 30s wait time after the first one is deployed fixes this.
  • I tried using hardhat's await for the 1st contract and adding the 1st contract as a dependency, but neither solutions worked so I resorted with the 30s wait (30 was an arbitrary number)

Additional Information

Related Issues

Closes #60

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address:

@MattWong-ca MattWong-ca marked this pull request as ready for review November 27, 2024 00:10
@xBalbinus xBalbinus merged commit 8714015 into main Nov 27, 2024
1 check passed
@xBalbinus xBalbinus deleted the fix-sequential-deployments branch December 3, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment script should properly deploy multiple contracts, add basic foundry tests for each contract
2 participants