This repository has been archived by the owner on Jan 17, 2024. It is now read-only.
Task/187 page logbuch home screen #36
Merged
+103
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from develop
…into feature/logbuch
IsAvaible
suggested changes
Dec 14, 2023
| ), | ||
| ); | ||
| FutureBuilder<List<db_post.Post>>( |
There was a problem hiding this comment.
Der Seperator zwischen den Beiträgen fehlt noch.
|
|
||
| class Logbook extends StatelessWidget { | ||
| const Logbook({super.key}); | ||
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| ImageManager im = ImageManager(); |
There was a problem hiding this comment.
Abkürzung "im" ist nicht besonders aussagekräftig, weil's eh nur einmal genutzt wird, können wir die Variabel ruhig imageManager nennen
| builder: | ||
| (BuildContext context, AsyncSnapshot<List<dynamic>> snapshot) { | ||
| if (snapshot.connectionState == ConnectionState.waiting) { | ||
| return const Center(child: CircularProgressIndicator()); |
There was a problem hiding this comment.
Loading Indicator ist horizontal und nicht vertikal zentriert.
| if (snapshot.connectionState == ConnectionState.waiting) { | ||
| return const Center(child: CircularProgressIndicator()); | ||
| } else if (snapshot.hasError) { | ||
| return Center(child: Text('Error: ${snapshot.error}')); |
There was a problem hiding this comment.
Wie beim loading indicator.
| children: [ | ||
| const Text( | ||
| 'Du hast noch keine Beiträge.', | ||
| textAlign: TextAlign.center, |
There was a problem hiding this comment.
Text ist imo bisschen klein, vielleicht
style: Theme.of(context).textTheme.displayMedium
?
| ], | ||
| ); | ||
| } else { | ||
| return const CircularProgressIndicator(); |
There was a problem hiding this comment.
Lieber
return SizedBox(height: 200, child: Center(child: const CircularProgressIndicator()));
sonst sieht der Indicator so lustig aus:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OP#187