Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement what @wence- described in this issue.
In this PR rewrite:
GenericDerivativeRuleset
,GradRuleset
,ReferenceGradRuleset
,so that they subclass
DAGTraverser
instead ofMultiFunction
.Old
GenericDerivativeRuleset
is still there asGenericDerivativeRulesetMultiFunction
, which is eventually to be removed.We should be able to incrementally remove all
MultiFunction
instances in the future.Performance checks:
holzapfel_ogden.py
(holzapfel_ogden):main
:average time required: 0.2262434959411621
this PR
:average time required: 0.2308340072631836
wence_test
(#69):main
:average time required: 0.18775153160095215
this PR
:average time required: 0.1888974905014038