Remove unused/unnecessary items from IntegralIR
#679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensd
changed the title
IntegralIR
jorgensd
requested review from
garth-wells,
mscroggs,
chrisrichardson and
IgorBaratta
IgorBaratta
approved these changes
Apr 15, 2024
|
Looks OK to me, please merge when ready. |
Im happy with it. Just want to check with @mscroggs that he agrees with what Im removing (even if it is clearly unused, as seem by the tests). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the usage of
iras temporary storage of variables.