Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in Section equality check. #674

Merged
merged 6 commits into from
Mar 13, 2024
Merged

Fix a bug in Section equality check. #674

merged 6 commits into from
Mar 13, 2024

Conversation

jorgensd
Copy link
Member

Only add definitions of variable if unique.
Resolves FEniCS/dolfinx#3102

@jorgensd
Fix a bug in Section equality check.
9404136 
Only add definitions of variable if unique.
Resolves FEniCS/dolfinx#3102
@jorgensd jorgensd requested review from IgorBaratta and jpdean March 13, 2024 11:50
@IgorBaratta
Copy link
Member

LGTM!
I'll try to cook up a test as discussed in slack.

jpdean
jpdean approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@jpdean jpdean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me

jorgensd
jorgensd commented Mar 13, 2024
View reviewed changes
@jorgensd jorgensd added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit 06957db Mar 13, 2024
9 checks passed
@jorgensd jorgensd deleted the dokken/submesh-duplicate-sections branch March 13, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpdean jpdean jpdean approved these changes

@IgorBaratta IgorBaratta IgorBaratta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Submesh form with derivative does not compile
3 participants
@jorgensd @IgorBaratta @jpdean