Add audio renderer via ALSA #326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallas
reviewed
Feb 28, 2022
renderers/CMakeLists.txt
Outdated
| @@ -47,11 +64,21 @@ if( BRCM_GLES_V2 AND BRCM_EGL AND OPENMAXIL AND BCM_HOST AND VCOS AND VCHIQ_ARM | |||
|
|
|||
| set( RENDERER_FLAGS "${RENDERER_FLAGS} -DHAS_RPI_RENDERER" ) | |||
| set( RENDERER_SOURCES ${RENDERER_SOURCES} audio_renderer_rpi.c video_renderer_rpi.c ) | |||
| set( RENDERER_LINK_LIBS ${RENDERER_LINK_LIBS} ilclient airplay fdk-aac h264-bitstream ) | |||
| # set( RENDERER_LINK_LIBS ${RENDERER_LINK_LIBS} ilclient airplay fdk-aac h264-bitstream ) | |||
There was a problem hiding this comment.
Can we remove the commented-out line?
There was a problem hiding this comment.
Yes. Removed extra lines in the last commit
|
Thank you very much for your contribution! I found some small issues with code style. Please excuse my nitpicking! Once these minor things are corrected, we'll gladly merge this in! Anything I overlooked @pallas ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new audio renderer that uses fdk-aac for decoding and ALSA for rendering