pyscanfcs/openfile.py: fix for numpy 2.0. #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As initially identified in [Debian bug #1095368], test_open_dat fails with numpy 2.0 and beyond with the following error: # Make a 32 bit array data = np.uint32(data16) > data[occ] = data16[occ + 1] + data16[occ + 2] * 65536 E OverflowError: Python integer 65536 out of bounds for uint16 This change uses the freshly converted data array to uint32 for the data concatenation instead of using the uint16 data16 array elements. [Debian bug #1095368]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095368
paulmueller
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As initially identified in Debian bug #1095368, test_open_dat fails with numpy 2.0 and beyond with the following error:
This change uses the freshly converted data array to uint32 for the data concatenation instead of using the uint16 data16 array elements.