Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to uv compile and install #347

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Switch to uv compile and install #347

merged 4 commits into from
Jun 14, 2024

Conversation

lukaspie
Copy link
Collaborator

@lukaspie lukaspie commented Jun 8, 2024

  • Replace pip-tools by uv like NOMAD did here
  • Use uv pip install to speed up the CI/CD (note that you need to pass the --system flag because the default of uv is that you work in a virtual environment) -> this reduces the runtime of the pytest.yaml CI/CD by 25%

As of python 3.12, setuptools is not anymore installed by default with python. If you don't use pip (which still has setuptools), you need to specify setuptools as a dependency in the pyproject.toml file. Since uv is used in the CI/CD workflows now (which doesn't come with a build backend), setuptools was added to the dependencies.

@coveralls
Copy link

coveralls commented Jun 8, 2024

Pull Request Test Coverage Report for Build 9431228501

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.603%

Totals Coverage Status
Change from base Build 9416111276: 0.0%
Covered Lines: 570
Relevant Lines: 584

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 8, 2024

Pull Request Test Coverage Report for Build 9431263862

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.603%

Totals Coverage Status
Change from base Build 9416111276: 0.0%
Covered Lines: 570
Relevant Lines: 584

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 8, 2024

Pull Request Test Coverage Report for Build 9431293291

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.603%

Totals Coverage Status
Change from base Build 9416111276: 0.0%
Covered Lines: 570
Relevant Lines: 584

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 13, 2024

Pull Request Test Coverage Report for Build 9505941776

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.603%

Totals Coverage Status
Change from base Build 9478793570: 0.0%
Covered Lines: 570
Relevant Lines: 584

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9505941776

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.603%

Totals Coverage Status
Change from base Build 9478793570: 0.0%
Covered Lines: 570
Relevant Lines: 584

💛 - Coveralls

Copy link
Collaborator

@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the question whether to use pip install or uv pip install this looks good

.github/workflows/build_docs.yml Show resolved Hide resolved
@lukaspie lukaspie merged commit 3a7d63d into master Jun 14, 2024
11 checks passed
@lukaspie lukaspie deleted the uv-compile-and-install branch June 14, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants