-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to uv compile and install #347
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9431228501Details
💛 - Coveralls |
lukaspie
force-pushed
the
uv-compile-and-install
branch
from
June 8, 2024 20:11
4822e51
to
8aa47f7
Compare
Pull Request Test Coverage Report for Build 9431263862Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9431293291Details
💛 - Coveralls |
2 tasks
Pull Request Test Coverage Report for Build 9505941776Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 9505941776Details
💛 - Coveralls |
domna
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the question whether to use pip install
or uv pip install
this looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uv pip install
to speed up the CI/CD (note that you need to pass the--system
flag because the default of uv is that you work in a virtual environment) -> this reduces the runtime of the pytest.yaml CI/CD by 25%As of python 3.12,
setuptools
is not anymore installed by default with python. If you don't use pip (which still has setuptools), you need to specifysetuptools
as a dependency in the pyproject.toml file. Since uv is used in the CI/CD workflows now (which doesn't come with a build backend),setuptools
was added to the dependencies.