change order of key mapping transform #993
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we perform key_mapping renames and then perform data_object transforms. However data object transforms have hard coded string values. This means that if we change the task and change the key_mapping the same hard coded data transforms will no longer work, i.e. key omat24_energy might not be present.
On the flip side, if we perform data transforms before key name remapping, this cleans up the transforms since most datasets have the keys energy and not datasetname_energy.
This PR changes the order so that we first perform data transforms, and then perform key renaming.