Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change logic to catch missing outputs #859

Merged
merged 6 commits into from
Sep 19, 2024
Merged

change logic to catch missing outputs #859

merged 6 commits into from
Sep 19, 2024

Conversation

wood-b
Copy link
Collaborator

@wood-b wood-b commented Sep 17, 2024

Small change to catch missing outputs instead of falling into the decomposition logic and getting a random error.

@wood-b wood-b requested review from lbluque and rayg1234 September 17, 2024 01:29
@wood-b wood-b added enhancement New feature or request patch Patch version release dont-close labels Sep 17, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/fairchem/core/trainers/ocp_trainer.py 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/fairchem/core/trainers/ocp_trainer.py 69.02% <0.00%> (-0.47%) ⬇️

lbluque
lbluque reviewed Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@lbluque lbluque left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for @rayg1234's suggestion this lgtm

@wood-b wood-b removed the dont-close label Sep 18, 2024
rayg1234
rayg1234 previously approved these changes Sep 18, 2024
View reviewed changes
@wood-b wood-b enabled auto-merge September 19, 2024 17:25
@misko misko self-requested a review September 19, 2024 19:25
@wood-b wood-b added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit c261f7f Sep 19, 2024
8 checks passed
@wood-b wood-b deleted the missing_output branch September 19, 2024 21:34
misko pushed a commit that referenced this pull request Jan 17, 2025
@wood-b @lbluque
change logic to catch missing outputs (#859)
e92bc93 
* change logic to catch missing outputs

* minor update, changed error type and added out list

* fix decomposition in output logic

---------

Co-authored-by: lbluque <[email protected]>
Former-commit-id: a26061e5bcc389494db16c1dc6ba81c1ca3a0bc4
beomseok-kang pushed a commit to beomseok-kang/fairchem that referenced this pull request Jan 27, 2025
@wood-b @lbluque
change logic to catch missing outputs (FAIR-Chem#859)
3fa1eaa 
* change logic to catch missing outputs

* minor update, changed error type and added out list

* fix decomposition in output logic

---------

Co-authored-by: lbluque <[email protected]>
Former-commit-id: 4d670fb997b0ba123152f2db9d12a40c71a9ab95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbluque lbluque lbluque left review comments

@misko misko misko approved these changes

@rayg1234 rayg1234 rayg1234 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request patch Patch version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wood-b @misko @rayg1234 @lbluque