Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pickle modification into main rank behind barrier #1061

Merged
merged 4 commits into from
Mar 14, 2025
Merged

Move pickle modification into main rank behind barrier #1061

merged 4 commits into from
Mar 14, 2025
+13 −7

Conversation

rayg1234
Copy link
Collaborator

@rayg1234 rayg1234 commented Mar 14, 2025 •
edited
Loading

Previously all ranks were modifying the pickle and can get into a race condition

Testing:

  • Local runs
  • slurm runs

Sorry, something went wrong.

rayg1234 added 2 commits March 14, 2025 20:25
@rayg1234
move pickle modification into main rank behind barrier
Loading
Loading status checks…
5e75342
@rayg1234
update
Loading
Loading status checks…
ab0d639
misko
misko approved these changes Mar 14, 2025
View reviewed changes
Copy link
Collaborator

@misko misko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! LGTM!

@rayg1234 rayg1234 added bug Something isn't working patch Patch version release labels Mar 14, 2025
rayg1234 added 2 commits March 14, 2025 20:33
@rayg1234
Merge remote-tracking branch 'origin' into rgao_wrap_remove_pickle_in…
Loading
Loading status checks…
10935d9 
…_master
@rayg1234
typo
Loading
Loading status checks…
2b7fbb4
@rayg1234 rayg1234 enabled auto-merge March 14, 2025 20:49
@rayg1234 rayg1234 added this pull request to the merge queue Mar 14, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/fairchem/core/_cli_hydra.py 75.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/fairchem/core/_cli_hydra.py 77.72% <75.00%> (+1.05%) ⬆️
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into main with commit 4914e7e Mar 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misko misko

Assignees
No one assigned
Labels
bug Something isn't working patch Patch version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rayg1234 @misko