Repository navigation
Improve PR prep workflow to create appropriate category snippets #7194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
29fdf44
Change PR prep to create balance snippets for balance PRs
lL1l1 372c96e
Improve label check
lL1l1 457caa0
try to fix syntax error with double quotes
lL1l1 ff6ba98
Fix category choices in documentation not being on new lines
lL1l1 5900e75
Add the remaining category creation
lL1l1 2021569
Avoid newlines and quotes in the env values
lL1l1 fde08e9
Prioritize "other" category over bug fixes
lL1l1 a8b4cae
Correct grammar in category documentation
lL1l1 9b52e4b
Ignore "area: balance" for creating balance snippets
lL1l1 3e840e1
Further grammar fixes
lL1l1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| {% unit <BlueprintID> %} | ||
| <Formatted Unit Name> | ||
| {% endunit %} | ||
| <Description> (#PR_NUMBER) | ||
| - <Category>: | ||
| - <Parameter Name>: <value before> -> <value after> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| - Your explanation here... [Don't forget to change the category in the filename] (#XYZW). | ||
| - Your explanation here... [Don't forget to change the category in the filename] (#PR_NUMBER). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.