Mnp#1
Merged
Merged
Conversation
This is _extremely_ specific, and was meant to be removed after a review in the game embedder PR. No idea how it found its way back in.
The spec says "After leave event, compositor must ignore requests from any text input instances until next enter event." Fixes an error on jay, which at least on 1.11.0 sends `zwp_text_input_v3::done` after `zwp_text_input_v3::leave`, which we didn't ignore, leading to a commit without a valid window id.
…frame Co-authored-by: Micky <66727710+Mickeon@users.noreply.github.com>
- Use this shorthand in code samples.
…ng using half floats in derivative functions
…as changed. It was a textureCube, but now it is a texture2D. For compatibility purposes we need to continue exposing a cube texture. So we need to add this scaffolding to properly sample from it.
When the same uniform set is bound multiple times within a render pass (e.g., OPAQUE pass then ALPHA pass with different instance buffers), the dynamic offset bits were being OR'd together, corrupting the packed frame indices. For example, if OPAQUE binds set 1 with frame_idx=1 (0x10) and ALPHA binds set 1 with frame_idx=2 (0x20), the OR produces 0x30 instead of the correct 0x20, causing the shader to read from the wrong buffer offset. This fix clears the relevant bits for each set being bound before OR'ing the new values, ensuring only the latest frame indices are used. Fixes rendering artifacts in the mobile renderer which uses two dynamic uniforms (uniform buffer + storage buffer) in set 1, unlike the clustered renderer which only has one.
…-warnings Add XROrigin3D scale warning
…7-camera2d-align-note Clarify `align()` behavior regarding `force_update_scroll()`
WaylandEmbedder: Fix `-Wduplicated-branches` warning
…esa-half-workaround Workaround crash in pipeline creation on Intel Mesa devices by avoiding using half floats in derivative functions
…er-spacing Improve animation player header spacing in modern theme
…_offsets Metal: Fix dynamic uniform buffer offset corruption when rebinding sets
…mport-freeze Fix importing projects with PNG assets freezes Web Editor
…nspector Hide animation library properties in inspector
…-uninit-desc Fix description for `resize_uninitialized`
Network: Normalize IP parsing, fix IPv6, tests
…urn-type Change return type for `Input.set_joy_light()` from `bool` to `void`
Fix downsampled radiance map generation
Overhaul compute shader based environment roughness calculation to improve performance and quality
Tweak quick open recursion error
Minor fixes for the project list item UI
…t_fix Fix speed being reset when it shouldn't in the game editor
…radius Fix inner tabs outer panel corners at zero radius
…le-warning Fix XROrigin3D scale warning
Fix dock tab styles not updating when changed in Editor Settings
Fix descriptions of custom types in CreateDialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.