Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #60: obtain VAST XML for a specific session #61

Merged
merged 1 commit into from
Oct 7, 2021
Merged

feat: #60: obtain VAST XML for a specific session #61

merged 1 commit into from
Oct 7, 2021

Conversation

birme
Copy link
Contributor

@birme birme commented Oct 6, 2021

This PR intends to solve #60 by providing an endpoint to obtain a VAST XML for a specific session:

GET /api/v1/sessions/:sessionId/vast

@birme birme requested a review from Nfrederiksen October 6, 2021 12:01
Nfrederiksen
Nfrederiksen approved these changes Oct 7, 2021
View reviewed changes
Copy link
Collaborator

@Nfrederiksen Nfrederiksen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. More convenient.

@birme birme merged commit fd453c0 into main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nfrederiksen Nfrederiksen Nfrederiksen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birme @Nfrederiksen