Fix #17 (work with SRT v1.4.2): Set proper sockaddr_in alloc size & resolve deprecation warning (use srt_create_socket instead srt_socket)
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…accept call, but SRT v1.4.2 is checking for this size to be large enough to write into it the actual address in the first place. anyhow, wether we read it or not, it doesn't matter, the allocated size of sockaddr_in is always the same (per any platform).
…e_socket + fix newline-chars
tchakabam
changed the title
sockaddr_in alloc size & resolve deprecation warning (use srt_create_socket instead srt_socket)
birme
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See for references:
https://github.com/Haivision/srt/blob/master/examples/test-c-server.c#L41
https://github.com/Haivision/srt/blob/master/examples/test-c-server.c#L76
Fixes #17