Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide a WHIP endpoint for audio from external devices #99

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

birme
Copy link
Contributor

@birme birme commented Jun 28, 2024

No description provided.

oshinongit
oshinongit previously approved these changes Aug 5, 2024
Copy link
Contributor

@oshinongit oshinongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell we are loading the new whip functionality as a separate api so there is a redundancy safety. There are some import lint warnings that should be resolved but otherwise it looks good to me.

@birme
Copy link
Contributor Author

birme commented Aug 5, 2024

From what I can tell we are loading the new whip functionality as a separate api so there is a redundancy safety. There are some import lint warnings that should be resolved but otherwise it looks good to me.

Except for that it is not working yet :)

@oshinongit
Copy link
Contributor

Aha, I see. Then obviously we should make it work, then test, then have a look again xD. Nice addition with the api unit tests though!

@oshinongit oshinongit dismissed their stale review August 5, 2024 11:09

Functionality not complete yet

@oshinongit
Copy link
Contributor

I have time over and could have a look at it if it is of priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants