Feat/global hotkeys #260
Open
Feat/global hotkeys #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d global-mute-btn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Changed logic
Hotkeys are now added to the global-state and added to each callState. This allows for a more complete experience with using the hotkeys.
Warnings and Errors
We still want to be able to block users from saving faulty hotkey-setups, these messages are now red and if a red message is present then saving wont be possible. If a yellow message is shown then it will be a warning to the user that a key used in another call is about to be added. This might be desirable so saving wont be blocked.
Added Master-Mute
A button for toggling the microphone mute-button is added. It is changeable from the hotkey-settings and when updated it will be updated for all current calls and all calls added on afterwards.
Minor fixes