fix: show volume control on supported devices #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saelmala
requested review from
malmen237 and
LucasMaupin
and removed request for
malmen237
malmen237
approved these changes
Dec 19, 2024
Saelmala
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volume control is not supported on iOS mobile and iPhone, so this PR makes sure those features are disabled for those platform. Volume control on Android devices are supported so that is allowed.
Hotkeys should not show on tablet but they did so I added a check for that as well.
I also noticed some undesired behavior with the volume slider: If you muted the speaker with the button, and then moved the slider, the button made it look like the speaker wasn't muted - but it was. Now I made it so that if the user mutes the speaker with the button, and then moves the slider - the speaker is unmuted.