Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/modal and button fixes on callpage #255

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

malmen237
Copy link
Contributor

#What does this do?

  • Unnecessary confirm-modal removed if user has routed on direct-link and not yet connected to call and then presses "home"-button or "return"-button.

  • If user is trying to change connected device and reselects the devices already connected to the call, the "save"-button will be disabled.

Copy link
Contributor

@Saelmala Saelmala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM - However, the Save button is blue when not disabled, and green when disabled, they should have the same color.. I think green is probably the best color here

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants