-
Couldn't load subscription status.
- Fork 1
Migrate Instances to routes #1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
xurxodev
wants to merge
41
commits into
development
Choose a base branch
from
feature/routes_as_instances
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to basic use case reuse the same instance repository with cache
- now is not necessary using routes
- Remove getApi from InstanceRepository - Mark GetInstanceApiUseCase as deprecated for the future
…_as_instances # Conflicts: # i18n/en.pot # i18n/es.po # i18n/fr.po # i18n/pt.po # src/data/instance/InstanceD2ApiRepository.ts # src/data/tracked-entity-instances/TEID2ApiRepository.ts # src/presentation/CompositionRoot.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
Bugs reported to dhis2
https://dhis2.atlassian.net/browse/DHIS2-20010
https://dhis2.atlassian.net/browse/DHIS2-20130
https://dhis2.atlassian.net/browse/DHIS2-20311
📹 Screenshots/Screen capture
🔥 Is there anything the reviewer should know to test it?
📑 Others
Any change in the GUI library? If so, what branch/PR?
Any change in the D2 Api? If so, what branch/PR?