Skip to content

[feature] Sync rule dependencies UI changes #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: development
Choose a base branch
from
Draft

[feature] Sync rule dependencies UI changes #1022

wants to merge 3 commits into from

Conversation

@MatiasArriola
Copy link
Contributor

📌 References

📝 Implementation

  • Rename titles in the MultiSelectors, and align them to the Selector boxes. Since the components don't support titles, a workaround was used styling from outside.
  • Add toggles
    • "Configure user dependencies" -> Include owner and sharing settings, Include users
    • "Configure organisation units dependencies" -> Include organisation units
  • The toggles will be disabled if default options are used (now defaults are include objects and references)
  • Disabling the toggles sets the options to the defaults.
  • Remove toggle for "Remove lastUpdated, lastUpdatedBy, created and createdBys".

TODO: confirm the removal of "Remove lastUpdated, lastUpdatedBy, created and createdBys". Also confirm if needed the remove the feature entirely and not just the UI.

📹 Screenshots/Screen capture

mdsync-selector-title
mdsync-dependencies-options.webm

@MatiasArriola
Update MetadataIncludeExcludeStep to include toggles and fix Multisel…
e9e6f98 
…ector title

- Add toggles before showing the dependencies dropdowns, based on defaults
- Extract SynchronizationRule syncParamsDefaults for this purpose, and a useConfigureDependencies hook to handle toggles state and logic.
- Change titles for MultiSelectors, and align titles to each Select box
@MatiasArriola
Delete toggle for removeUserNonEssentialObjects
0dbc132
@MatiasArriola
Fix updating multiple ObjectsAndReferences at once
b69460b 
refactor was needed to include a single changeObjectsAndReferences callback instead of multiple separate calls, to avoid race conditions when updating one prop after another.
@bundlemon
Copy link

bundlemon bot commented Jul 31, 2025

BundleMon

No change in files bundle size

Groups updated (1)
Status Path Size Limits
✅ Build Folder
./**/*
 1.93MB (+256B +0.01%) +20%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MatiasArriola