Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all dependencies #764

Merged
merged 7 commits into from
Jul 2, 2018
Merged

Update all dependencies #764

merged 7 commits into from
Jul 2, 2018

Conversation

XVincentX
Copy link
Member

@XVincentX XVincentX commented Jul 2, 2018

This PR goes through all the deps and update them to the latest version.

Note: this PR contains an upgrade from Winston2 to Winston3. I went though the changelog and made all the necessary changes to make it work correctly.

It also updates upath to 1.0.5 that does not have any compatibility problem with node 10.

Connect #752
Closes #752

@XVincentX XVincentX added this to the 1.10.0 milestone Jul 2, 2018
@codecov
Copy link

codecov bot commented Jul 2, 2018

Codecov Report

Merging #764 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #764      +/-   ##
==========================================
- Coverage   89.03%   89.01%   -0.02%     
==========================================
  Files         132      132              
  Lines        3576     3570       -6     
==========================================
- Hits         3184     3178       -6     
  Misses        392      392
Impacted Files Coverage Δ
lib/logger.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34e4634...9555049. Read the comment docs.

Copy link
Member

@kevinswiber kevinswiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be good to get @DrMegavolt's take.

I know we have at least one user who's overriding the winston logger. We should add to the release notes that the approach to doing this might change.

FYI: @mikedshaffer, I believe we discussed this on Gitter. Not sure if the log-hijacking approach we discussed will still work after this winston upgrade. These changes are planned to roll out with [email protected].

@XVincentX XVincentX merged commit 0753845 into master Jul 2, 2018
@XVincentX XVincentX deleted the feat/deps-update branch July 2, 2018 17:01
gatherchou pushed a commit to yilu-tech/express-gateway that referenced this pull request Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants