-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all dependencies #764
Conversation
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
==========================================
- Coverage 89.03% 89.01% -0.02%
==========================================
Files 132 132
Lines 3576 3570 -6
==========================================
- Hits 3184 3178 -6
Misses 392 392
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would be good to get @DrMegavolt's take.
I know we have at least one user who's overriding the winston logger. We should add to the release notes that the approach to doing this might change.
FYI: @mikedshaffer, I believe we discussed this on Gitter. Not sure if the log-hijacking approach we discussed will still work after this winston upgrade. These changes are planned to roll out with [email protected].
…pdate Update all dependencies
This PR goes through all the deps and update them to the latest version.
Note: this PR contains an upgrade from Winston2 to Winston3. I went though the changelog and made all the necessary changes to make it work correctly.
It also updates
upath
to 1.0.5 that does not have any compatibility problem with node 10.Connect #752
Closes #752