Don't touch process.stdin #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commenting the lines that refer to `process.stdin` prevents the windows error messages on Experience-Monks#42
|
|
@StreetStrider is-windows just checks |
|
@rafaelcastrocouto, this is why package exists. For me it is up to package to take care of such details. When win64 actually shows this package will get an update (it have 5K downloads per day). |
|
Guess you are right ... I did a pull request there! |
|
Thanks for the PR, I just pushed something similar. Will revisit later this or next week when I get my hands on a Windows PC for testing. |
|
👍 thx @mattdesl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commenting the lines that refer to
process.stdinprevents the windows error messages on #42Maybe we should add
if (/^win/.test(process.platform))on those lines or find a real fix for the stdin problem.