-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated electron version #17
Conversation
Sadly we can't upgrade yet because the newest version of Electron crashes the inspector regularly (at least on OSX). So this PR will be on hold until this is figured out: Thanks for testing. Maybe there is another way we can tackle this in the mean time? |
I'm on OSX myself, not had a crash yet. Been using it for a couple hours straight, with Babel 6 and my PR version. Anything specific it crashes on? I'm running a fairly large project and not had a problem. |
I will give it a bit more testing and let you know. |
I'm on OSX El Captain v10.11, if that makes a difference. |
Something I just noticed - debugging |
Whats the failure error on gulp? |
|
What version of node are you running locally? That looks like you're way lower than the one electron uses, 5.1.1 in the latest electron version. I could be wrong though, but I occasionally get this when upgrading node versions. See this issue. |
Thanks for the info. I think it should be OK to upgrade to the newest Electron, and it might also help with other bugs like #15. I will revert back if I run into any major problems. Sorry I didn't merge your PR... Next time! |
Updated electron package version to the latest.
Without this Babel 6 via require hook would not work if using
util.inherits
, investigation seemed to point towards "use strict" and Object.prototype being read only, seems babel or electron was forcing strictness in that scenario on the older version.Error stack:
Tried disabling various babel plugins to no effect, in the end the Electron update did the trick.
Preset
babel-preset-es2015-node5
now works perfectly. As does justes2015
.