Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -DSQLITE_MAX_FUNCTION_ARG=32767 #2066

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

aldo-expensify
Copy link
Contributor

Details

Fixed Issues

Fixes https://github.com/Expensify/Auth/pull/13795#discussion_r1917043241

Tests

You could manually test this by checking out this PR: https://github.com/Expensify/Auth/pull/13795 and running the SharePolicy tests. Check that the test SharePolicyTest::testUnshareApproverThousandsOfEmployeesInEmployeeList passes.


Internal Testing Reminder: when changing bedrock, please compile auth against your new changes

@aldo-expensify aldo-expensify requested a review from flodnv January 15, 2025 18:43
@aldo-expensify aldo-expensify self-assigned this Jan 15, 2025
@flodnv flodnv merged commit 8d609f3 into main Jan 15, 2025
1 check passed
@flodnv flodnv deleted the aldo_increase-sqlite-function-args branch January 15, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants