Remove log params that are not related to Bedrock #1995
Merged
+8
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luacmartins
approved these changes
Dec 2, 2024
danieldoglas
deleted the
revert-1989-revert-1988-dsilva_removeLogParamsThatAreNotRelatedToBedrock
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting this back to the codebase now that we found why Auth tests were failing.
Reverts #1989
Explanation of Change
This PR moves all params whitelist that are specific to auth to a function in auth that will be called when the auth plugin is started.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/448720