Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: On selecting a category/ tags by multiple tapping, user directed to conversation page." #56000

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

yuwenmemon
Copy link
Contributor

@yuwenmemon yuwenmemon commented Jan 29, 2025

Reverts #55036

Fixes #55940

@yuwenmemon yuwenmemon requested a review from a team as a code owner January 29, 2025 20:33
@melvin-bot melvin-bot bot requested a review from robertjchen January 29, 2025 20:34
Copy link

melvin-bot bot commented Jan 29, 2025

@robertjchen Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team January 29, 2025 20:34
Copy link
Contributor

🚧 @yuwenmemon has triggered a test build. You can view the workflow run here.

@yuwenmemon yuwenmemon requested review from puneetlath and removed request for robertjchen January 29, 2025 20:45
Copy link
Contributor

@puneetlath puneetlath merged commit 8e125f4 into main Jan 29, 2025
14 of 17 checks passed
@puneetlath puneetlath deleted the revert-55036-krishna2323/issue/53344 branch January 29, 2025 21:30
@melvin-bot melvin-bot bot added the Emergency label Jan 29, 2025
Copy link

melvin-bot bot commented Jan 29, 2025

@puneetlath looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@puneetlath
Copy link
Contributor

Merged without checklists since it's a straight revert for a deploy blocker.

OSBotify pushed a commit that referenced this pull request Jan 29, 2025
…ue/53344

Revert "fix: On selecting a category/ tags by multiple tapping, user directed to conversation page."

(cherry picked from commit 8e125f4)

(CP triggered by yuwenmemon)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Jan 29, 2025
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.0.91-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Copy link
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.91-2 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CP Staging marks PRs that have been CP'd to staging Ready To Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reports-Tapping on expenses, page is not responsive
3 participants