Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "Implemented International Bank Account flow" #54729

Merged
merged 2 commits into from
Jan 2, 2025
Merged

[CP Staging] Revert "Implemented International Bank Account flow" #54729

merged 2 commits into from
Jan 2, 2025
+199 −1,738

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Jan 1, 2025 •
edited by Beamanator
Loading

Reverts #52322

This is an attempt to solve several deploy blockers

Fixes a ton of blockers & issues, see #54743

@tgolen tgolen requested a review from a team as a code owner January 1, 2025 18:28
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 1, 2025

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@melvin-bot melvin-bot bot requested a review from grgia January 1, 2025 18:29
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 1, 2025

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team January 1, 2025 18:29
@tgolen
Copy link
Contributor Author

tgolen commented Jan 1, 2025

No need to do the checklists or have tests pass since this is a straight revert

@mjasikowski
Copy link
Contributor

Resolved conflicts

Beamanator
Beamanator approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a clean straight revert 👍

@Beamanator Beamanator merged commit a2c8842 into main Jan 2, 2025
13 of 16 checks passed
@Beamanator Beamanator deleted the revert-52322-intl-bank-account branch January 2, 2025 12:36
@melvin-bot melvin-bot bot added the Emergency label Jan 2, 2025
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 2, 2025

@Beamanator looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@Beamanator Beamanator changed the title Revert "Implemented International Bank Account flow" [CP Staging] Revert "Implemented International Bank Account flow" Jan 2, 2025
@Beamanator
Copy link
Contributor

Beamanator commented Jan 2, 2025 •
edited
Loading

Not emergency, revert & possibly reintroduced a few small eslint issues

This was referenced Jan 2, 2025
Open
Merged
@OSBotify
Copy link
Contributor

OSBotify commented Jan 2, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@shubham1206agra shubham1206agra mentioned this pull request Jan 2, 2025
Closed
48 tasks
OSBotify pushed a commit that referenced this pull request Jan 2, 2025
@Beamanator @OSBotify
Merge pull request #54729 from Expensify/revert-52322-intl-bank-account
1f9eb85 
Revert "Implemented International Bank Account flow"

(cherry picked from commit a2c8842)

(CP triggered by Beamanator)
@os-botify os-botify bot mentioned this pull request Jan 2, 2025
Merged
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Jan 2, 2025
@Beamanator
Copy link
Contributor

CP conflicts are being handled in #54756

mjasikowski added a commit that referenced this pull request Jan 2, 2025
@mjasikowski
Merge pull request #54756 from Expensify/Beamanator-cherry-pick-stagi…
318aa29 
…ng-54729-1

🍒 Cherry pick PR #54729 to staging 🍒
@Beamanator
Copy link
Contributor

Staging deploy running here: https://github.com/Expensify/App/actions/runs/12583365276

@github-actions github-actions bot mentioned this pull request Jan 2, 2025
Open
68 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.0.80-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@lschurr lschurr mentioned this pull request Jan 3, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beamanator Beamanator Beamanator approved these changes

@grgia grgia Awaiting requested review from grgia

Assignees
No one assigned
Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tgolen @mjasikowski @Beamanator @OSBotify