-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unable to upload a receipt size larger than 15mb #54728
base: main
Are you sure you want to change the base?
Conversation
@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
thanks @dominictb. But from what I can see here, we need to fallback to CONST.DEFAULT_NUMBER_ID with the default values being numbers, correct? |
@Themoonalsofall These values already have their fallback values in the function params. Also, reportID and currentUserPersonalDetails?.accountID never be undefined. You can remove the optional chaining operator from currentUserPersonalDetails as well. That's redundant. |
Co-authored-by: Dominic <[email protected]>
Co-authored-by: Dominic <[email protected]>
@Themoonalsofall Are you reusing your old recordings from the previous PR? That's not appropriate. Please test the whole flow carefully and add new recordings. |
@Themoonalsofall Also test the crash bugs that were caused by the previous PR. Make sure everything works well. |
@dominictb i added new recordings, retested all regressions and it worked well |
Waiting for retesting with this specific attachment #54700 before proceeding. |
Explanation of Change
Fixed Issues
$ #53341
PROPOSAL: #53341 (comment)
Tests
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
a.mov
Android: mWeb Chrome
am.mov
iOS: Native
i.mov
iOS: mWeb Safari
im.mov
MacOS: Chrome / Safari
w.mov
MacOS: Desktop
d.mov