Migrate/textinput growlnotification attachmentmodal animte to reanimate #53321

sumo-slonik · 2024-11-29T13:57:17Z

Explanation of Change

Swap use animated from react-native to react-native-reanimated so we have big performance gains in animations

Fixed Issues

$ #52920

PROPOSAL:
here

Tests

Text input

create a room
entering the room
selecting edit room name
click and un-click text input

expected behavior:
the label above the text input should move up at the moment of focus on the input
label should return to its original place when focus on text input disappears.

Growl nottification

This is quite hard, the easiest way to do it is to manually add the code that will call it, you need to add the following code:

Growl.show('TEST NOTIFICATION HARDCODED ONLY AS AN EXAMPLE', CONST.GROWL.SUCCESS, 3000);

expected behavior:
A notification with a bounce-in effect containing the text will appear:
TEST NOTIFICATION HARDCODED ONLY AS AN EXAMPLE

Attachment modal:

Animated here is the appearance of the send button in the modal, the animation is not very visible but behaves the same as the one using animated

Verify that no errors appear in the JS console

Offline tests

Are not needed

QA Steps

Go to Wallet
Try to enable your wallet (I know its not going to work with fake data)
Go through the onfido flow and put in random data so it fails
Verify that you can see the growl with error just fine

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android.web.mp4

iOS: Native

ios.native.mp4

iOS: mWeb Safari

ios.web.mp4

MacOS: Chrome / Safari

desktop.web.mp4

MacOS: Desktop

desktop.native.mp4

melvin-bot · 2024-11-29T13:57:21Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

blazejkustra

LGTM!

src/components/AttachmentModal.tsx

review from Błazej Co-authored-by: Błażej Kustra <[email protected]>

…ntmodal_animte_to_reanimate

…ion_attachmentmodal_animte_to_reanimate' into migrate/textinput_growlnotification_attachmentmodal_animte_to_reanimate

melvin-bot · 2024-12-02T10:38:37Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2024-12-02T13:58:57Z

Is there anything here you need us to review from a design-perspective?

shubham1206agra · 2024-12-02T14:03:02Z

No

sumo-slonik · 2024-12-04T12:15:53Z

@shubham1206agra
Hi, can you tell when you will find the time to check this PR?

shubham1206agra · 2024-12-05T07:01:32Z

@sumo-slonik Sorry for the delay
Can you fix the conflicts?

…ntmodal_animte_to_reanimate

blazejkustra · 2024-12-06T10:28:13Z

@sumo-slonik Sorry for the delay Can you fix the conflicts?

@shubham1206agra sumo-slonik is OOO today, I resolved these conflicts for you 😄

shubham1206agra · 2024-12-06T17:04:02Z

@blazejkustra I am still seeing conflicts

…ntmodal_animte_to_reanimate

blazejkustra · 2024-12-06T17:11:52Z

Most likely a PR was reverted which caused the same conflicts but the other way around

blazejkustra · 2024-12-06T17:12:05Z

Should be good now @shubham1206agra

shubham1206agra · 2024-12-07T09:36:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-07.at.3.01.29.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-12-07.at.1.40.20.PM.mov

iOS: Native

Screen.Recording.2024-12-07.at.2.51.38.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-12-07.at.1.29.35.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-07.at.1.26.21.PM.mov

MacOS: Desktop

Screen.Recording.2024-12-07.at.1.44.48.PM.mov

mountiny

Thanks! Before merging @sumo-slonik can you please update the QA steps to be clearer for QA on how to test these changes on staging. They cannot hard code this obviously so I think that they would not know how to test this from your instructions

sumo-slonik · 2024-12-09T10:50:41Z

Hi @mountiny , the problem is that unfortunately I am not able to find an easy use of this popup, so I can correct the other steps if they are not clear but testing the growl popup can be problematic

mountiny · 2024-12-09T10:57:26Z

@sumo-slonik where is it used on what pages/ components?

sumo-slonik · 2024-12-09T13:03:17Z

For example, in a component:
OnfidoStep.tsx
Growl.error(translate('onfidoStep.genericError'), 10000);.

mountiny · 2024-12-09T13:28:17Z

I have added some small test which hopefully will be good for qa to follow

melvin-bot · 2024-12-09T13:29:41Z

Congrats, that’s your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It’s an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks!

OSBotify · 2024-12-09T13:38:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-09T16:28:56Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.73-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

sumo-slonik · 2024-12-10T10:37:17Z

@mountiny thank you very much for your help 🙇

github-actions · 2024-12-10T22:47:10Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.73-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

sumo-slonik added 5 commits November 29, 2024 13:53

migrate AttachmentModal.tsx

329f273

migrate GrowlNotification

1dc5415

migrate TextInput

e1f6577

add worklet signatures to functions

d092d64

migrate to new reanimated api from .value to .set() .get()

7e532ab

blazejkustra approved these changes Dec 2, 2024

View reviewed changes

src/components/AttachmentModal.tsx Outdated Show resolved Hide resolved

sumo-slonik and others added 4 commits December 2, 2024 11:18

Update src/components/AttachmentModal.tsx

8a22884

review from Błazej Co-authored-by: Błażej Kustra <[email protected]>

Merge branch 'main' into migrate/textinput_growlnotification_attachme…

b89aa6d

…ntmodal_animte_to_reanimate

remove unnecessary import after merge

59e3e75

Merge remote-tracking branch 'origin/migrate/textinput_growlnotificat…

1c514e1

…ion_attachmentmodal_animte_to_reanimate' into migrate/textinput_growlnotification_attachmentmodal_animte_to_reanimate

sumo-slonik marked this pull request as ready for review December 2, 2024 10:38

sumo-slonik requested review from a team as code owners December 2, 2024 10:38

melvin-bot bot requested review from shubham1206agra and removed request for a team December 2, 2024 10:38

sumo-slonik mentioned this pull request Dec 2, 2024

Replace react-native Animated API with react-native-reanimated #52920

Open

Merge branch 'main' into migrate/textinput_growlnotification_attachme…

ca02a2b

…ntmodal_animte_to_reanimate

Merge branch 'main' into migrate/textinput_growlnotification_attachme…

a4d1f67

…ntmodal_animte_to_reanimate

shubham1206agra approved these changes Dec 7, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny December 7, 2024 09:37

mountiny assigned sumo-slonik Dec 8, 2024

mountiny approved these changes Dec 8, 2024

View reviewed changes

mountiny merged commit 034b2d9 into Expensify:main Dec 9, 2024
18 checks passed

github-actions bot mentioned this pull request Dec 9, 2024

Deploy Checklist: New Expensify 2024-12-09 #53762

Closed

70 tasks

blazejkustra mentioned this pull request Jan 10, 2025

[HOLD for payment 2025-02-04] [$125] iOS - Extra spacing before field label #54971

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate/textinput growlnotification attachmentmodal animte to reanimate #53321

Migrate/textinput growlnotification attachmentmodal animte to reanimate #53321

sumo-slonik commented Nov 29, 2024 •

edited by mountiny

Loading

melvin-bot bot commented Nov 29, 2024

blazejkustra left a comment

melvin-bot bot commented Dec 2, 2024

shawnborton commented Dec 2, 2024

shubham1206agra commented Dec 2, 2024

sumo-slonik commented Dec 4, 2024

shubham1206agra commented Dec 5, 2024

blazejkustra commented Dec 6, 2024

shubham1206agra commented Dec 6, 2024

blazejkustra commented Dec 6, 2024

blazejkustra commented Dec 6, 2024

shubham1206agra commented Dec 7, 2024

mountiny left a comment

sumo-slonik commented Dec 9, 2024

mountiny commented Dec 9, 2024

sumo-slonik commented Dec 9, 2024

mountiny commented Dec 9, 2024

melvin-bot bot commented Dec 9, 2024

OSBotify commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

sumo-slonik commented Dec 10, 2024

github-actions bot commented Dec 10, 2024

Migrate/textinput growlnotification attachmentmodal animte to reanimate #53321

Migrate/textinput growlnotification attachmentmodal animte to reanimate #53321

Conversation

sumo-slonik commented Nov 29, 2024 • edited by mountiny Loading

Explanation of Change

Fixed Issues

Tests

Text input

Growl nottification

Attachment modal:

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 29, 2024

blazejkustra left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Dec 2, 2024

shawnborton commented Dec 2, 2024

shubham1206agra commented Dec 2, 2024

sumo-slonik commented Dec 4, 2024

shubham1206agra commented Dec 5, 2024

blazejkustra commented Dec 6, 2024

shubham1206agra commented Dec 6, 2024

blazejkustra commented Dec 6, 2024

blazejkustra commented Dec 6, 2024

shubham1206agra commented Dec 7, 2024

Reviewer Checklist

Screenshots/Videos

mountiny left a comment

Choose a reason for hiding this comment

sumo-slonik commented Dec 9, 2024

mountiny commented Dec 9, 2024

sumo-slonik commented Dec 9, 2024

mountiny commented Dec 9, 2024

melvin-bot bot commented Dec 9, 2024

OSBotify commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

sumo-slonik commented Dec 10, 2024

github-actions bot commented Dec 10, 2024

sumo-slonik commented Nov 29, 2024 •

edited by mountiny

Loading