[NO QA]: Corporate Cards - Amex custom feed #50781

narefyev91 · 2024-10-15T08:17:12Z

Details

Corporate Cards - Amex custom feed

Fixed Issues

$ #50449
PROPOSAL:

Tests

Open any workspace
Enable Company Cards
Click "Add company card"
Select American Express
Observe a correct new screen (with 2 options - corporate and business)
Press Next - observe that error is shown (when nothing is selected)
Select Corporate - verify that option is selected and green checkmark is shown
Click Next - verify that next screen will show Instructions
Go back - verify that Amex custom feed selecting is shown
Selecting Business - will be done in separate PR

Verify that no errors appear in the JS console

Offline tests

Same logic as it was done before

QA Steps

Open any workspace
Enable Company Cards
Click "Add company card"
Select American Express
Observe a correct new screen (with 2 options - corporate and business)
Press Next - observe that error is shown (when nothing is selected)
Select Corporate - verify that option is selected and green checkmark is shown
Click Next - verify that next screen will show Instructions
Go back - verify that Amex custom feed selecting is shown
Selecting Business - will be done in separate PR

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios1.mov

iOS: mWeb Safari

ios-web1.mov

MacOS: Chrome / Safari

web1.mov

MacOS: Desktop

desktop1.mov

melvin-bot · 2024-10-15T08:17:17Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf

simple changes, just one change place, I will continue with the checklist

src/pages/workspace/companyCards/addNew/AmexCustomFeed.tsx

allgandalf · 2024-10-15T08:42:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-15.at.2.38.37.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-10-15.at.2.40.09.PM.mov

iOS: Native

Screen.Recording.2024-10-15.at.2.28.42.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-10-15.at.2.32.45.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-15.at.2.15.09.PM.mov

MacOS: Desktop

Screen.Recording.2024-10-15.at.2.21.22.PM.mov

allgandalf · 2024-10-15T08:44:50Z

src/pages/workspace/companyCards/addNew/AmexCustomFeed.tsx

+            return;
+        }
+        CompanyCards.setAddNewCompanyCardStepAndData({
+            step: typeSelected === CONST.COMPANY_CARDS.AMEX_CUSTOM_FEED.CORPORATE ? CONST.COMPANY_CARDS.STEP.CARD_INSTRUCTIONS : CONST.COMPANY_CARDS.STEP.BANK_CONNECTION,


Note to reviewer(@mountiny): When the custom feed is business according to design doc:

Clicking Next after selecting American Express Business Cards moves you to the bank UI step to establish the feed connection.

We are yet to establish that so for now we would move to bank connection step again

Can we instead hide that option under the direct feeds beta?

AmexCustomFeed page is already available only under direct feeds beta

allgandalf

LGTM, matches the doc, left one comment ^. Looks good to merge 🚀

src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx

src/pages/workspace/companyCards/addNew/CardInstructionsStep.tsx

OSBotify · 2024-10-15T14:53:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-17T02:00:41Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-18T18:49:31Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.50-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Corporate Cards - Amex custom feed

dd69e6c

narefyev91 requested a review from a team as a code owner October 15, 2024 08:17

melvin-bot bot requested a review from allgandalf October 15, 2024 08:17

melvin-bot bot removed the request for review from a team October 15, 2024 08:17

allgandalf suggested changes Oct 15, 2024

View reviewed changes

src/pages/workspace/companyCards/addNew/AmexCustomFeed.tsx Show resolved Hide resolved

allgandalf reviewed Oct 15, 2024

View reviewed changes

Add dot to the end

5d60d67

allgandalf approved these changes Oct 15, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny October 15, 2024 09:11

VickyStash reviewed Oct 15, 2024

View reviewed changes

src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx Outdated Show resolved Hide resolved

add correct check

ab61ef3

allgandalf reviewed Oct 15, 2024

View reviewed changes

src/pages/workspace/companyCards/addNew/CardInstructionsStep.tsx Show resolved Hide resolved

allgandalf reviewed Oct 15, 2024

View reviewed changes

src/pages/workspace/companyCards/addNew/CardInstructionsStep.tsx Outdated Show resolved Hide resolved

improvement

e61e96b

mountiny approved these changes Oct 15, 2024

View reviewed changes

mountiny merged commit e61b1fb into Expensify:main Oct 15, 2024
18 checks passed

github-actions bot mentioned this pull request Oct 17, 2024

Deploy Checklist: New Expensify 2024-10-17 #50969

Closed

90 tasks

melvin-bot bot mentioned this pull request Oct 18, 2024

[HOLD for payment 2024-10-25] [Direct Feeds] [App] Adding Direct Card Feed: Amex direct feeds #50449

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NO QA]: Corporate Cards - Amex custom feed #50781

[NO QA]: Corporate Cards - Amex custom feed #50781

narefyev91 commented Oct 15, 2024

melvin-bot bot commented Oct 15, 2024

allgandalf left a comment

allgandalf commented Oct 15, 2024 •

edited

Loading

allgandalf Oct 15, 2024

mountiny Oct 15, 2024

narefyev91 Oct 15, 2024

allgandalf left a comment

OSBotify commented Oct 15, 2024

github-actions bot commented Oct 17, 2024

github-actions bot commented Oct 18, 2024

[NO QA]: Corporate Cards - Amex custom feed #50781

[NO QA]: Corporate Cards - Amex custom feed #50781

Conversation

narefyev91 commented Oct 15, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 15, 2024

allgandalf left a comment

Choose a reason for hiding this comment

allgandalf commented Oct 15, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allgandalf Oct 15, 2024

Choose a reason for hiding this comment

mountiny Oct 15, 2024

Choose a reason for hiding this comment

narefyev91 Oct 15, 2024

Choose a reason for hiding this comment

allgandalf left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 15, 2024

github-actions bot commented Oct 17, 2024

github-actions bot commented Oct 18, 2024

allgandalf commented Oct 15, 2024 •

edited

Loading