Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "Add back qr code download feature" #49907

Merged
merged 1 commit into from
Sep 30, 2024
Merged

[CP Staging] Revert "Add back qr code download feature" #49907

merged 1 commit into from
Sep 30, 2024

Conversation

lakchote
Copy link
Contributor

Reverts #49595 as it's tied to a blocker related to the library used react-native-viewshot.

The problem didn't occur while testing on a debug build.

To see the discussion and get more details, please check #49868 (comment)

@lakchote lakchote self-assigned this Sep 30, 2024
@lakchote lakchote requested a review from a team as a code owner September 30, 2024 03:15
@melvin-bot melvin-bot bot requested review from marcochavezf and removed request for a team September 30, 2024 03:15
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 30, 2024

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Julesssss
Copy link
Contributor

Ignoring checklist

@Julesssss Julesssss merged commit b9226f4 into main Sep 30, 2024
16 of 19 checks passed
@Julesssss Julesssss deleted the revert-49595-lucien/add-back-qr-code-download branch September 30, 2024 09:08
@melvin-bot melvin-bot bot added the Emergency label Sep 30, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 30, 2024

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@Julesssss
Copy link
Contributor

Context, revert needed for blocker

OSBotify pushed a commit that referenced this pull request Sep 30, 2024
@Julesssss @OSBotify
Merge pull request #49907 from Expensify/revert-49595-lucien/add-back…
e5c9173 
…-qr-code-download

[CP Staging] Revert "Add back qr code download feature"

(cherry picked from commit b9226f4)

(CP triggered by Julesssss)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Sep 30, 2024
@github-actions github-actions bot mentioned this pull request Sep 30, 2024
Closed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.41-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.41-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.41-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

lakchote added a commit that referenced this pull request Dec 9, 2024
@lakchote
Revert "Merge pull request #49907 from Expensify/revert-49595-lucien/…
1d566c2 
…add-back-qr-code-download"

This reverts commit b9226f4, reversing
changes made to d187665.
@github-actions github-actions bot mentioned this pull request Dec 13, 2024
Closed
60 tasks
@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.76-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.0.76-12 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julesssss Julesssss Julesssss approved these changes

@marcochavezf marcochavezf marcochavezf approved these changes

Assignees

@lakchote lakchote

Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lakchote @Julesssss @OSBotify @marcochavezf