Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pressing tab #49623

Merged
merged 2 commits into from
Sep 26, 2024
Merged

fix pressing tab #49623

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e7abce
fix pressing tab
Nodebrute Sep 23, 2024
57a2a65
add accessibilityLabel
Nodebrute Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/WorkspaceSwitcherPage/WorkspacesSectionHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function WorkspacesSectionHeader() {
</View>
<Tooltip text={translate('workspace.new.newWorkspace')}>
<PressableWithFeedback
accessible={false}
accessibilityLabel=""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding accessibilityLabel with an empty string here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize; I saw it in another component and used it as a reference. I can’t locate that component, but I’ve fixed the issue.

role={CONST.ROLE.BUTTON}
onPress={() => {
const activeRoute = Navigation.getActiveRouteWithoutParams();
Expand Down
Loading