fix: Error when selecting distance rate that no longer has tax rate #49044

daledah · 2024-09-12T07:36:26Z

Details

Fixed Issues

$ #47613
PROPOSAL: #47613 (comment)

Tests

Precondition:

Track tax is enabled.
Create a Distance rate X that has Tax rate and Tax reclaimable on.

Steps:

Go to workspace settings > Taxes
Delete the tax rate that is assigned to Distance Rate X from the precondition
Go to the distance rate page
Select Distance rate X
Verify that: the tax rate is empty and Tax reclaimable on is hidden

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition:

Track tax is enabled.
Create a Distance rate X that has Tax rate and Tax reclaimable on.

Steps:

Go to workspace settings > Taxes
Delete the tax rate that is assigned to Distance Rate X from the precondition
Go to the distance rate page
Select Distance rate X
Verify that: the tax rate is empty and Tax reclaimable on is hidden

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-12.at.15.08.00.mp4

Android: mWeb Chrome

Screen.Recording.2024-09-12.at.15.00.27.mp4

iOS: Native

Screen.Recording.2024-09-12.at.15.17.01.mp4

iOS: mWeb Safari

Screen.Recording.2024-09-12.at.15.14.53.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-09-12.at.14.27.30.mp4

MacOS: Desktop

Screen.Recording.2024-09-12.at.15.18.52.mp4

melvin-bot · 2024-09-12T19:55:14Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

daledah · 2024-09-12T20:02:02Z

FYI, looks like the server send Onyx data of distance rate that still has the deleted tax rate when calling OpenPolicyTaxesPage:

I don't know if this is expected behavior, if it is indeed a bug then we should fix the bug on BE side as well, as mentioned in my proposal

src/libs/actions/TaxRate.ts

DylanDylann · 2024-09-18T09:46:08Z

@daledah Changed files ESLint check is failed. Because it is minor, could you also fix this eslint problem?

src/types/onyx/Policy.ts

src/libs/actions/TaxRate.ts

DylanDylann · 2024-09-19T09:46:49Z

@MonilBhavsar This PR looks good. But we need to update OpenPolicyDistanceRatesPage API from BE to remove the deleted tax rate from policy.cumtomUnit

MonilBhavsar · 2024-09-19T18:45:37Z

Okay, I'll work on it...

MonilBhavsar · 2024-09-19T18:45:53Z

Do we need to HOLD on that? or we can proceed with the App PR?

DylanDylann · 2024-09-24T03:07:45Z

@MonilBhavsar The App PR looks good. Waiting for BE change

MonilBhavsar · 2024-09-24T05:58:08Z

Do we need to HOLD on that? or we can proceed with the App PR?

We're holding on backend change?

DylanDylann · 2024-09-24T08:24:19Z

@MonilBhavsar Yes, we are holding on backend change

MonilBhavsar · 2024-09-24T18:57:25Z

Okay thanks! I'll work on it...

DylanDylann · 2024-10-02T02:24:28Z

@MonilBhavsar Do we have any new updates?

MonilBhavsar · 2024-10-03T18:45:25Z

@DylanDylann no update here, sorry. I changed timezones and focussing on some critical issues. I still expected to be done by EOW

daledah · 2024-10-10T03:17:32Z

@MonilBhavsar Is there any new update?

MonilBhavsar · 2024-10-10T16:59:16Z

#47613 (comment)

MonilBhavsar · 2024-10-15T04:43:25Z

@daledah @DylanDylann Fix is deployed on staging

daledah · 2024-10-15T15:16:37Z

@MonilBhavsar FE Looks good now, deleted tax rate is also removed from Onyx

MonilBhavsar · 2024-10-16T03:41:22Z

Thanks! @DylanDylann could you please take a look once

DylanDylann · 2024-10-16T09:19:03Z

@daledah Please help to merge the latest main

DylanDylann · 2024-10-16T10:08:28Z

@daledah Currently, when updating to another distance rate (that don't have tax) on distance request, the BE don't return errors anymore and the tax is updated to 0%

So we need to update the test step again, this is my suggestion:

Precondition:

Track tax is enabled.
Create a Distance rate X that has Tax rate and Tax reclaimable on.

Go to workspace settings > Taxes
Delete the tax rate that is assigned to Distance Rate X from the precondition
Go to the distance rate page
Select Distance rate X
Verify that the tax rate is empty and Tax reclaimable on is hidden

daledah · 2024-10-16T10:14:27Z

@DylanDylann I updated.

DylanDylann · 2024-10-16T10:32:00Z

Thanks for quick update

DylanDylann · 2024-10-16T10:43:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-16.at.17.42.53.mov

Android: mWeb Chrome

Screen.Recording.2024-10-16.at.17.38.04.mov

iOS: Native

Screen.Recording.2024-10-16.at.17.40.09.mov

iOS: mWeb Safari

Screen.Recording.2024-10-16.at.17.37.26.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-16.at.17.35.45.mov

MacOS: Desktop

Screen.Recording.2024-10-16.at.17.36.21.mov

DylanDylann · 2024-10-16T10:50:01Z

While reviewing this PR I discovered an error log on Android and IOS when going to distance rate page (this change doesn't cause this)

Reported on Slack: https://expensify.slack.com/archives/C049HHMV9SM/p1729075718314489

MonilBhavsar · 2024-10-16T11:17:37Z

While reviewing this PR I discovered an error log on Android and IOS when going to distance rate page (this change doesn't cause this)

Reported on Slack: https://expensify.slack.com/archives/C049HHMV9SM/p1729075718314489

Thank you! 🙌

MonilBhavsar

Looks good, thanks!

OSBotify · 2024-10-16T11:33:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-17T01:58:41Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-18T18:47:31Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.50-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

daledah added 2 commits September 12, 2024 14:29

fix: Error when selecting distance rate that no longer has tax rate

cbdc530

fix: undefined

d849eb1

daledah marked this pull request as ready for review September 12, 2024 19:55

daledah requested a review from a team as a code owner September 12, 2024 19:55

melvin-bot bot requested review from DylanDylann and removed request for a team September 12, 2024 19:55

daledah mentioned this pull request Sep 12, 2024

[HOLD for payment 2024-10-25] [$250] [P2P Distance] Distance rate - Error when selecting distance rate that no longer has tax rate #47613

Closed

5 tasks

DylanDylann reviewed Sep 17, 2024

View reviewed changes

src/libs/actions/TaxRate.ts Outdated Show resolved Hide resolved

fix: change undefined to null in onyx data

af0bbb2

DylanDylann reviewed Sep 18, 2024

View reviewed changes

src/libs/actions/TaxRate.ts Outdated Show resolved Hide resolved

fix: add missing key, refactor withOnyx

6c5127e

DylanDylann reviewed Sep 19, 2024

View reviewed changes

src/types/onyx/Policy.ts Outdated Show resolved Hide resolved

src/libs/actions/TaxRate.ts Outdated Show resolved Hide resolved

src/libs/actions/TaxRate.ts Outdated Show resolved Hide resolved

daledah added 2 commits September 19, 2024 17:56

Merge branch 'main' into fix/47613

b80a3ec

refactor: onyx keys, types

a456b62

fix: clean onyx data

4d94b11

daledah added 2 commits October 4, 2024 01:08

Merge branch 'main' into fix/47613

2e4be35

fix: lint

af3f047

daledah added 2 commits October 15, 2024 12:21

Merge branch 'main' into fix/47613

9a79d20

Merge branch 'main' into fix/47613

8dd137b

Merge branch 'main' into fix/47613

60d54e5

DylanDylann approved these changes Oct 16, 2024

View reviewed changes

melvin-bot bot requested a review from MonilBhavsar October 16, 2024 10:50

DylanDylann approved these changes Oct 16, 2024

View reviewed changes

MonilBhavsar approved these changes Oct 16, 2024

View reviewed changes

MonilBhavsar merged commit f60b99c into Expensify:main Oct 16, 2024
19 checks passed

github-actions bot mentioned this pull request Oct 17, 2024

Deploy Checklist: New Expensify 2024-10-17 #50969

Closed

90 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Error when selecting distance rate that no longer has tax rate #49044

fix: Error when selecting distance rate that no longer has tax rate #49044

daledah commented Sep 12, 2024 •

edited

Loading

melvin-bot bot commented Sep 12, 2024

daledah commented Sep 12, 2024 •

edited

Loading

DylanDylann commented Sep 18, 2024

DylanDylann commented Sep 19, 2024

MonilBhavsar commented Sep 19, 2024

MonilBhavsar commented Sep 19, 2024

DylanDylann commented Sep 24, 2024

MonilBhavsar commented Sep 24, 2024

DylanDylann commented Sep 24, 2024

MonilBhavsar commented Sep 24, 2024

DylanDylann commented Oct 2, 2024 •

edited

Loading

MonilBhavsar commented Oct 3, 2024 •

edited

Loading

daledah commented Oct 10, 2024

MonilBhavsar commented Oct 10, 2024

MonilBhavsar commented Oct 15, 2024

daledah commented Oct 15, 2024

MonilBhavsar commented Oct 16, 2024

DylanDylann commented Oct 16, 2024

DylanDylann commented Oct 16, 2024

daledah commented Oct 16, 2024

DylanDylann commented Oct 16, 2024

DylanDylann commented Oct 16, 2024

DylanDylann commented Oct 16, 2024

MonilBhavsar commented Oct 16, 2024

MonilBhavsar left a comment

OSBotify commented Oct 16, 2024

github-actions bot commented Oct 17, 2024

github-actions bot commented Oct 18, 2024

fix: Error when selecting distance rate that no longer has tax rate #49044

fix: Error when selecting distance rate that no longer has tax rate #49044

Conversation

daledah commented Sep 12, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 12, 2024

daledah commented Sep 12, 2024 • edited Loading

DylanDylann commented Sep 18, 2024

DylanDylann commented Sep 19, 2024

MonilBhavsar commented Sep 19, 2024

MonilBhavsar commented Sep 19, 2024

DylanDylann commented Sep 24, 2024

MonilBhavsar commented Sep 24, 2024

DylanDylann commented Sep 24, 2024

MonilBhavsar commented Sep 24, 2024

DylanDylann commented Oct 2, 2024 • edited Loading

MonilBhavsar commented Oct 3, 2024 • edited Loading

daledah commented Oct 10, 2024

MonilBhavsar commented Oct 10, 2024

MonilBhavsar commented Oct 15, 2024

daledah commented Oct 15, 2024

MonilBhavsar commented Oct 16, 2024

DylanDylann commented Oct 16, 2024

DylanDylann commented Oct 16, 2024

daledah commented Oct 16, 2024

DylanDylann commented Oct 16, 2024

DylanDylann commented Oct 16, 2024

Reviewer Checklist

Screenshots/Videos

DylanDylann commented Oct 16, 2024

MonilBhavsar commented Oct 16, 2024

MonilBhavsar left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 16, 2024

github-actions bot commented Oct 17, 2024

github-actions bot commented Oct 18, 2024

daledah commented Sep 12, 2024 •

edited

Loading

daledah commented Sep 12, 2024 •

edited

Loading

DylanDylann commented Oct 2, 2024 •

edited

Loading

MonilBhavsar commented Oct 3, 2024 •

edited

Loading