Fix the issue of RHP not opening smoothly #48143

wildan-m · 2024-08-28T06:38:03Z

Details

Fix the issue of RHP not opening smoothly after selecting any option in room details.

Fixed Issues

$ #44812
PROPOSAL: #44812 (comment)

Tests

Non Desktop

Log out ND if user is logged in
Navigate to a public room, e.g. https://staging.new.expensify.com/r/4865807136424891
Tap the header to open the details
Select any option

Verify that no errors appear in the JS console

Desktop

Log out ND if user is logged in
In OS menu, Click View > Toggle Developer Tools
In Console tab, execute window.location.href = '/r/4865807136424891'
Navigate to a public room, e.g. https://staging.new.expensify.com/r/4865807136424891
Tap the header to open the details
Select any option

Verify that no errors appear in the JS console

Offline tests

Same as test

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

WhatsApp.Video.2024-08-28.at.13.03.21.mp4

Android: mWeb Chrome

Kapture.2024-08-29.at.09.35.18.mp4

iOS: Native

Kapture.2024-08-28.at.10.23.28.mp4

iOS: mWeb Safari

Kapture.2024-08-28.at.13.11.38.mp4

MacOS: Chrome / Safari

Kapture.2024-08-28.at.13.15.07.mp4

MacOS: Desktop

Kapture.2024-08-29.at.09.25.41.mp4

…x/44812-react-navigation-lottie-transition

melvin-bot · 2024-08-28T06:38:08Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…x/44812-react-navigation-lottie-transition

sobitneupane · 2024-08-29T09:13:30Z

@wildan-m There is some jitter/lag on other platforms as well. Can we apply the change you suggested in the issue to other platforms as well?

wildan-m · 2024-08-29T13:32:47Z

@sobitneupane The optimization has been implemented across all platforms. Is there ever a scenario where we wouldn't need it? Should we include the shouldLoadAfterInteraction prop?

…x/44812-react-navigation-lottie-transition

wildan-m · 2024-09-03T02:08:20Z

@sobitneupane bump #48143 (comment)

sobitneupane · 2024-09-03T11:26:27Z

Is there ever a scenario where we wouldn't need it?

I am not sure if there is any. Let's make sure to test it extensively.

Should we include the shouldLoadAfterInteraction prop?

Sorry. I didn't get you. Is it an existing prop? I would require more context.

wildan-m · 2024-09-04T01:30:17Z

@sobitneupane, shouldLoadAfterInteraction is a new prop introduced as a feature flag for this PR.

I’ve noticed that the delay is quite noticeable on desktop especially the background image. Should we consider enabling this feature only for small screens, as larger devices tend to have better responsiveness?

sobitneupane · 2024-09-04T09:13:08Z

I’ve noticed that the delay is quite noticeable on desktop especially the background image. Should we consider enabling this feature only for small screens, as larger devices tend to have better responsiveness?

@wildan-m Can you please upload videos for each case?

sobitneupane · 2024-09-04T09:19:03Z

shouldLoadAfterInteraction is a new prop introduced as a feature flag for this PR.

So, Are you saying that, in addition to the current change, we will be passing the shouldLoadAfterInteraction prop to LottieView and Image to let those components know if the interaction is complete?

…x/44812-react-navigation-lottie-transition

wildan-m · 2024-09-05T06:15:11Z

@sobitneupane this is before and after video, is this delay differences acceptable?

Before	After
Kapture.2024-09-05.at.13.06.18.mp4	Kapture.2024-09-05.at.13.04.30.mp4

sobitneupane · 2024-09-06T08:54:15Z

@wildan-m Can we limit the change made in this PR to RHP only? The issue occurs on RHP. So, if it is possible to limit the change in RHP(and small screen), we should be good.

wildan-m · 2024-09-06T09:05:53Z

@sobitneupane do you know existing function to detect if a page opened in RHP ? passing shouldLoadAssetAfterInteraction props will modify too many child components of SignInModal

wildan-m · 2024-09-06T09:10:10Z

@sobitneupane signinpagemodal identify RHP by anonimity

App/src/pages/signin/SignInModal.tsx

Lines 30 to 34 in ec012fe

    
           if (!isAnonymousUser) { 
        
               // Signing in RHP is only for anonymous users 
        
               Navigation.isNavigationReady().then(() => Navigation.dismissModal()); 
        
               App.openApp(); 
        
           }

Should we do the same for lottie and bg image?

…x/44812-react-navigation-lottie-transition

…tive

wildan-m · 2024-09-06T10:09:07Z

@sobitneupane the PR has been updated

sobitneupane · 2024-09-09T10:06:55Z

src/components/Lottie/index.tsx

    const aspectRatioStyle = styles.aspectRatioLottie(source);

    // If the image fails to load, app is in background state, animation file isn't ready, or the splash screen isn't hidden yet,
    // we'll just render an empty view as the fallback to prevent
    // 1. memory leak, see issue: https://github.com/Expensify/App/issues/36645
    // 2. heavy rendering, see issue: https://github.com/Expensify/App/issues/34696
-    if (isError || appState.isBackground || !animationFile || splashScreenState !== CONST.BOOT_SPLASH_STATE.HIDDEN) {
+    // 3. lag on react navigation transitions, see issue: https://github.com/Expensify/App/issues/44812
+    if (isError || appState.isBackground || !animationFile || splashScreenState !== CONST.BOOT_SPLASH_STATE.HIDDEN || (!isInteractionComplete && isLastRouteInRHP && isSmallScreenWidth)) {


@wildan-m I believe we are applying the change to larger screen as well. So, should we get rid of isSmallScreenWidth from the condition. Please let me know if I am missing something.

@sobitneupane my isLastRouteInRHP function does not cover current screen, it will be false if the prev screen is not in RHP, i.e. call sign in page from sign in button. I thought that isSmallScreenWidth might still needed.

Kapture.2024-09-09.at.21.02.59.mp4

What are your thoughts on using isAnonymous?

@sobitneupane I believe just using navigationRef?.isReady() is enough. When loading through a direct link, it's always false, but when the sign-in page modal comes from other screens, it's always true. What's your opinion?

@wildan-m It should be fine using isAnonymous if the issue is existent only for anonymous user even is small screen devices. I am not sure about navigationRef?.isReady().

@sobitneupane Do you know if there are any other anonymously loaded lottie files besides Hands.lottie? I will create a shouldLoadAfterInteraction for the Lottie component to prevent the code from affecting other Lottie assets. Let me know if you have any objections.

@sobitneupane the code has been updated

…x/44812-react-navigation-lottie-transition

sobitneupane

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-12.at.17.44.36.mov

iOS: Native

Screen.Recording.2024-09-12.at.17.35.07.mov

iOS: mWeb Safari

Screen.Recording.2024-09-12.at.17.27.41.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-12.at.17.23.07.mov

MacOS: Desktop

Screen.Recording.2024-09-12.at.17.41.53.mov

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

OSBotify · 2024-09-12T13:06:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-12T21:37:30Z

🚀 Deployed to staging by https://github.com/nkuoch in version: 9.0.34-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-13T22:45:12Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.34-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

wildan-m added 6 commits August 23, 2024 16:44

Puclic room make rn navigation transition smoother on from public group

5dec110

remove unnecessary codes

f9bb0c9

remove unnecessary code

f476d8b

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

de1aa28

…x/44812-react-navigation-lottie-transition

Add ios specific code for lottie, refactor

38b3dad

Fix lint and do prettier

57c0d67

wildan-m requested a review from a team as a code owner August 28, 2024 06:38

melvin-bot bot requested review from sobitneupane and removed request for a team August 28, 2024 06:38

wildan-m changed the title ~~Wildan/fix/44812 react navigation lottie transition~~ Fix the issue of RHP not opening smoothly Aug 28, 2024

wildan-m mentioned this pull request Aug 28, 2024

[AWAITING PAYMENT] [$250] iOS- Public room- RHP not opens smoothly after selecting any option from room details #44812

Closed

6 tasks

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

4d3c690

…x/44812-react-navigation-lottie-transition

Apply delaying heavy assets for all platform

3a3dafa

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

759a230

…x/44812-react-navigation-lottie-transition

wildan-m added 2 commits September 5, 2024 12:59

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

9fa89c9

…x/44812-react-navigation-lottie-transition

add missing code

af25187

wildan-m added 2 commits September 6, 2024 16:34

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

414b6c2

…x/44812-react-navigation-lottie-transition

limit check based on isLastRouteRHP and small screen width for non-na…

51d7912

…tive

run lint

748bef6

wildan-m added 2 commits September 6, 2024 17:10

run lint

0212eb3

add null check

2d078be

sobitneupane reviewed Sep 9, 2024

View reviewed changes

wildan-m added 4 commits September 9, 2024 20:54

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

fb1ff9c

…x/44812-react-navigation-lottie-transition

Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

bac68ec

…x/44812-react-navigation-lottie-transition

remove unnecessary code

312c6d8

add isAnonymousUser condition to asset load optimization

0afa871

sobitneupane reviewed Sep 12, 2024

View reviewed changes

sobitneupane approved these changes Sep 12, 2024

View reviewed changes

melvin-bot bot requested a review from nkuoch September 12, 2024 12:21

nkuoch approved these changes Sep 12, 2024

View reviewed changes

nkuoch merged commit 37161bc into Expensify:main Sep 12, 2024
16 of 18 checks passed

github-actions bot mentioned this pull request Sep 12, 2024

Deploy Checklist: New Expensify 2024-09-12 #49139

Closed

30 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the issue of RHP not opening smoothly #48143

Fix the issue of RHP not opening smoothly #48143

wildan-m commented Aug 28, 2024 •

edited

Loading

melvin-bot bot commented Aug 28, 2024

sobitneupane commented Aug 29, 2024

wildan-m commented Aug 29, 2024

wildan-m commented Sep 3, 2024

sobitneupane commented Sep 3, 2024

wildan-m commented Sep 4, 2024

sobitneupane commented Sep 4, 2024

sobitneupane commented Sep 4, 2024

wildan-m commented Sep 5, 2024

sobitneupane commented Sep 6, 2024 •

edited

Loading

wildan-m commented Sep 6, 2024

wildan-m commented Sep 6, 2024

wildan-m commented Sep 6, 2024

sobitneupane Sep 9, 2024

wildan-m Sep 9, 2024

wildan-m Sep 9, 2024

wildan-m Sep 9, 2024

sobitneupane Sep 11, 2024

wildan-m Sep 11, 2024

wildan-m Sep 11, 2024

sobitneupane left a comment

sobitneupane left a comment

OSBotify commented Sep 12, 2024

OSBotify commented Sep 12, 2024

OSBotify commented Sep 13, 2024

Fix the issue of RHP not opening smoothly #48143

Fix the issue of RHP not opening smoothly #48143

Conversation

wildan-m commented Aug 28, 2024 • edited Loading

Details

Fixed Issues

Tests

Non Desktop

Desktop

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 28, 2024

sobitneupane commented Aug 29, 2024

wildan-m commented Aug 29, 2024

wildan-m commented Sep 3, 2024

sobitneupane commented Sep 3, 2024

wildan-m commented Sep 4, 2024

sobitneupane commented Sep 4, 2024

sobitneupane commented Sep 4, 2024

wildan-m commented Sep 5, 2024

sobitneupane commented Sep 6, 2024 • edited Loading

wildan-m commented Sep 6, 2024

wildan-m commented Sep 6, 2024

wildan-m commented Sep 6, 2024

sobitneupane Sep 9, 2024

Choose a reason for hiding this comment

wildan-m Sep 9, 2024

Choose a reason for hiding this comment

wildan-m Sep 9, 2024

Choose a reason for hiding this comment

wildan-m Sep 9, 2024

Choose a reason for hiding this comment

sobitneupane Sep 11, 2024

Choose a reason for hiding this comment

wildan-m Sep 11, 2024

Choose a reason for hiding this comment

wildan-m Sep 11, 2024

Choose a reason for hiding this comment

sobitneupane left a comment

Choose a reason for hiding this comment

Screenshots/Videos

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

OSBotify commented Sep 12, 2024

OSBotify commented Sep 12, 2024

OSBotify commented Sep 13, 2024

wildan-m commented Aug 28, 2024 •

edited

Loading

sobitneupane commented Sep 6, 2024 •

edited

Loading