[NO QA] Feat: company cards empty state #47782

waterim · 2024-08-21T12:58:51Z

Details

Fixed Issues

$ #47376
PROPOSAL: N/A

Tests

Test with collect Plan:

Open any workspace in which you are an admin
Go to More Features
Verify that user sees a new item "Company Cards"
Switch on - verify that upgrade plan right panel will be shown
Upgrade to a new plan
Switch on -> verify that a new row appears in left menu item
Verify that the new menu item is highlighted
Click in Company Cards - Verify that a new screen is opened
Verify empty state is correct

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

None

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile

…cards-empty-state

melvin-bot · 2024-08-23T17:45:08Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Pujan92 · 2024-08-25T15:31:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Pujan92 · 2024-08-25T15:32:22Z

src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx

@@ -32,6 +33,7 @@ function WorkspaceCompanyCardPage({route}: WorkspaceCompanyCardPageProps) {
                shouldShowOfflineIndicatorInWideScreen
            >
                <View style={[styles.mt3, shouldUseNarrowLayout ? styles.workspaceSectionMobile : styles.workspaceSection]} />
+                <WorkspaceCompanyCardPageEmptyState route={route} />


Can we consider rendering this based on condition or will it be handled in the next PR's?

I think we'll be handling this in the next related PR's 👍

src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx

src/pages/workspace/companyCards/WorkspaceCompanyCardPageEmptyState.tsx

assets/images/companyCards/cardIllustration.svg

src/pages/workspace/companyCards/WorkspaceCompanyCardPageEmptyState.tsx

assets/images/simple-illustrations/simple-illustration__magnifyingglass-money.svg

waterim · 2024-08-26T18:21:12Z

@Pujan92 @shawnborton fixed images
Also added a paddingBottom: 30 to the main container to get the desired height (220) for the whole container but for the illustration 190 height as you asked me and figma requires

shawnborton · 2024-08-26T18:27:11Z

Also added a paddingBottom: 30 to the main container to get the desired height (220) for the whole container but for the illustration 190 height as you asked me and figma requires

Instead of needing to do that, can't we just give the top part a fixed height?

Pujan92 · 2024-08-26T19:23:58Z

How about these changes @waterim ?

emptyStateCardIllustrationContainer: {
    height: 220,
},

emptyStateCardIllustration: {
    width: 164,
    height: 190,
},

illustrationStyle={styles.emptyStateCardIllustration}
illustrationContainerStyle={[styles.emptyStateCardIllustrationContainer, styles.justifyContentStart]}

waterim · 2024-08-26T19:26:10Z

We can do this way too, will update now!

waterim · 2024-08-26T19:28:11Z

@Pujan92 Updated

Pujan92 · 2024-08-26T19:39:13Z

@Pujan92 Updated

Thanks @waterim, do we need to add [NO QA] in the PR title as enabling this feature isn't supported by the backend yet?

waterim · 2024-08-26T19:40:11Z

Hm, I think so, yes

Pujan92

LGTM!

…cards-empty-state

narefyev91 · 2024-08-29T11:33:35Z

@iwiznia friendly bump here - we need to get this moving forward - because some other PRs relate on this one. Thanks!

trjExpensify · 2024-08-29T14:34:46Z

Ionatan is out of office this week, maybe @robertjchen can do the secondary review?

robertjchen · 2024-08-29T17:38:06Z

Yep, taking a look!

robertjchen

thanks!

OSBotify · 2024-08-29T19:47:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-30T18:49:18Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 9.0.27-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-02T23:27:00Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.27-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

waterim added 11 commits August 20, 2024 17:06

add new illustration

d1d07dd

add new screen

bee7deb

add translations

3f65359

update illustration

ad44f2d

add screen and route

757d77a

Merge remote-tracking branch 'upstream/main' into feat-47376-Company-…

21cfd1b

…cards-empty-state

add new illustration

b0acd03

update en translation

a7c0536

add pending state to the screen

b56d72e

update empty state, remove unused component and props

172be73

remove duplicates after merge

3c91986

waterim marked this pull request as ready for review August 23, 2024 17:45

waterim requested review from a team as code owners August 23, 2024 17:45

melvin-bot bot requested a review from Pujan92 August 23, 2024 17:45

melvin-bot bot removed the request for review from a team August 23, 2024 17:45

Pujan92 reviewed Aug 25, 2024

View reviewed changes

src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx Outdated Show resolved Hide resolved

Pujan92 reviewed Aug 25, 2024

View reviewed changes

src/pages/workspace/companyCards/WorkspaceCompanyCardPageEmptyState.tsx Outdated Show resolved Hide resolved

Pujan92 reviewed Aug 25, 2024

View reviewed changes

assets/images/companyCards/cardIllustration.svg Outdated Show resolved Hide resolved

Pujan92 reviewed Aug 25, 2024

View reviewed changes

src/pages/workspace/companyCards/WorkspaceCompanyCardPageEmptyState.tsx Outdated Show resolved Hide resolved

waterim added 2 commits August 26, 2024 12:14

fix colors

d55177f

remove unused view

7d02ec4

shawnborton reviewed Aug 26, 2024

View reviewed changes

assets/images/simple-illustrations/simple-illustration__magnifyingglass-money.svg Outdated Show resolved Hide resolved

shawnborton mentioned this pull request Aug 26, 2024

[NO QA]: Feed Added Empty State #48000

Merged

50 tasks

waterim changed the title ~~Feat 47376 company cards empty state~~ Feat: company cards empty state Aug 26, 2024

waterim added 2 commits August 26, 2024 20:17

update illustrations

15d9bd5

update container, add padding and add sizes to the image

c034b3d

update illustrations

facfa50

update container stylings

d8be3cb

return accidentaly removed container

f373929

waterim changed the title ~~Feat: company cards empty state~~ [NO QA] Feat: company cards empty state Aug 26, 2024

Pujan92 approved these changes Aug 26, 2024

View reviewed changes

melvin-bot bot requested a review from iwiznia August 26, 2024 19:49

Merge remote-tracking branch 'upstream/main' into feat-47376-Company-…

2d67c14

…cards-empty-state

robertjchen approved these changes Aug 29, 2024

View reviewed changes

robertjchen merged commit 9275b86 into Expensify:main Aug 29, 2024
16 checks passed

github-actions bot mentioned this pull request Aug 30, 2024

Deploy Checklist: New Expensify 2024-08-30 #48360

Closed

45 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NO QA] Feat: company cards empty state #47782

[NO QA] Feat: company cards empty state #47782

waterim commented Aug 21, 2024 •

edited

Loading

melvin-bot bot commented Aug 23, 2024

Pujan92 commented Aug 25, 2024 •

edited

Loading

Pujan92 Aug 25, 2024

robertjchen Aug 29, 2024

waterim commented Aug 26, 2024

shawnborton commented Aug 26, 2024

Pujan92 commented Aug 26, 2024

waterim commented Aug 26, 2024

waterim commented Aug 26, 2024

Pujan92 commented Aug 26, 2024

waterim commented Aug 26, 2024

Pujan92 left a comment

narefyev91 commented Aug 29, 2024

trjExpensify commented Aug 29, 2024

robertjchen commented Aug 29, 2024

robertjchen left a comment

OSBotify commented Aug 29, 2024

OSBotify commented Aug 30, 2024

OSBotify commented Sep 2, 2024

[NO QA] Feat: company cards empty state #47782

[NO QA] Feat: company cards empty state #47782

Conversation

waterim commented Aug 21, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 23, 2024

Pujan92 commented Aug 25, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

Pujan92 Aug 25, 2024

Choose a reason for hiding this comment

robertjchen Aug 29, 2024

Choose a reason for hiding this comment

waterim commented Aug 26, 2024

shawnborton commented Aug 26, 2024

Pujan92 commented Aug 26, 2024

waterim commented Aug 26, 2024

waterim commented Aug 26, 2024

Pujan92 commented Aug 26, 2024

waterim commented Aug 26, 2024

Pujan92 left a comment

Choose a reason for hiding this comment

narefyev91 commented Aug 29, 2024

trjExpensify commented Aug 29, 2024

robertjchen commented Aug 29, 2024

robertjchen left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 29, 2024

OSBotify commented Aug 30, 2024

OSBotify commented Sep 2, 2024

waterim commented Aug 21, 2024 •

edited

Loading

Pujan92 commented Aug 25, 2024 •

edited

Loading