-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Individual workspace is in 'Send from' field #47288
Conversation
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / Safari47288-web-safari-001.mp4MacOS: Desktop47288-desktop-001.mp4iOS: mWeb Safari47288-mweb-safari-001.mp4Android: Native47288-android-native-001.mp4Android: mWeb Chrome47288-mweb-chrome-001.mp4iOS: Native47288-ios-native-001.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nkdengineer.
LGTM and tests well too.
@thienlnam Over to you for review. Thanks.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.21-0 🚀
|
This PR is failing because of issue #47572 The issue is reproducible in: Android IOS Bug6573884_1723822791649.video_2024-08-16_11-37-05.mp4 |
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀
|
This is a non-issue and has been closed |
Details
Fixed Issues
$ #46705
PROPOSAL: #46705 (comment)
Tests
Precondition: account has Individual workspace as default and at least one existing group workspace.
Offline tests
QA Steps
Precondition: account has Individual workspace as default and at least one existing group workspace.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
ios.mov
Android: mWeb Chrome
android-mweb.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
web-resize.mp4
MacOS: Desktop
desktop.mov