Offline and errors pattern in Sage Intacct integration #46294

war-in · 2024-07-26T13:08:01Z

Details

Fixed Issues

$ #45406 - partially fixes
PROPOSAL:

Tests

Test errors:

Set Simulate failing network in Troubleshooting (you can set MAX_REQUEST_RETRIES to 0 to get errors faster).
Go to Settings -> Workspaces -> your sage intacct workspace -> Accounting.
Go through every page and try changing values.
See that there are RBRs and error messages when request fails.

Offline tests

Go to Settings -> Workspaces -> your xero workspace -> Accounting.
Go through every page and try changing values.
See that changed values are on opacity 50%.

QA Steps

Test errors:

Set Simulate failing network in Troubleshooting (you can set MAX_REQUEST_RETRIES to 0 to get errors faster).
Go to Settings -> Workspaces -> your sage intacct workspace -> Accounting.
Go through every page and try changing values.
See that there are RBRs and error messages when request fails.

PR Author Checklist

Screenshots/Videos

Android: Native

android.-.native.mov

Android: mWeb Chrome

andorid.-.web.mov

iOS: Native

iOS: mWeb Safari

ios.-.web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…tacct # Conflicts: # src/libs/PolicyUtils.ts

…tacct

src/pages/workspace/accounting/intacct/import/SageIntacctEditUserDimensionsPage.tsx

melvin-bot · 2024-07-29T14:50:58Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ikevin127 · 2024-07-29T23:20:48Z

@war-in @trjExpensify Currently blocked by not having Sage Intacct credentials, if anyone can provide them on Slack (DM) or here please do so, otherwise I'd have to pass this PR to somebody else for review.

Note: Also asked on Slack here.

war-in · 2024-07-30T09:36:33Z

@ikevin127 @trjExpensify I'm not sure if I can distribute those credentials 😅

AFAIK @hungvu193 has them and should be able to verify this PR

hungvu193 · 2024-07-30T09:43:33Z

@war-in @trjExpensify Currently blocked by not having Sage Intacct credentials, if anyone can provide them on Slack (DM) or here please do so, otherwise I'd have to pass this PR to somebody else for review.

Note: Also asked on Slack here.

Yuwen can help you, I replied in Slack btw 😄

hungvu193 · 2024-07-30T09:52:00Z

Ah I see the point here.
@ikevin127 Let me handle this one as it's a part of SageIntacct project.

…tacct

src/libs/PolicyUtils.ts

hungvu193 · 2024-07-31T10:28:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-31.at.22.32.52.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-07-31.at.22.21.48.mov

iOS: mWeb Safari

Screen.Recording.2024-07-31.at.22.28.45.mov

MacOS: Chrome / Safari

Chrome.mov

MacOS: Desktop

Desktop.mov

war-in · 2024-07-31T10:57:03Z

@hungvu193 comments addressed!

hungvu193

LGTM

deetergp

LGTM

OSBotify · 2024-07-31T22:54:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-02T01:42:17Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.0.16-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-06T04:02:28Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.16-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

war-in added 10 commits July 23, 2024 15:55

add Sage Intacct settings to functions

19d1f82

unify SageIntacct export page

98eefe5

unify SageIntacct import and advanced pages

78b23fd

Merge branch 'refs/heads/main' into war-in/offline-and-errors-sage-in…

51b0bf9

…tacct # Conflicts: # src/libs/PolicyUtils.ts

Merge branch 'refs/heads/main' into war-in/offline-and-errors-sage-in…

0319f26

…tacct

show errors in correct place

bce9f1f

Merge branch 'refs/heads/main' into war-in/offline-and-errors-sage-in…

9d311f1

…tacct

remaining fixes

1c9af91

fix lint

a6f6942

rollback unnecessary changes

3a41c01

SzymczakJ approved these changes Jul 29, 2024

View reviewed changes

src/pages/workspace/accounting/intacct/import/SageIntacctEditUserDimensionsPage.tsx Outdated Show resolved Hide resolved

add DIMENSION_PREFIX

eb05f5c

war-in marked this pull request as ready for review July 29, 2024 14:50

war-in requested a review from a team as a code owner July 29, 2024 14:50

melvin-bot bot requested review from ikevin127 and removed request for a team July 29, 2024 14:50

trjExpensify requested review from hungvu193 and removed request for ikevin127 July 30, 2024 10:03

war-in added 3 commits July 30, 2024 15:41

Merge branch 'refs/heads/main' into war-in/offline-and-errors-sage-in…

289bbe3

…tacct

update Advanced Page

c5c875e

update user dimensions page

28c759b

hungvu193 reviewed Jul 30, 2024

View reviewed changes

src/libs/PolicyUtils.ts Outdated Show resolved Hide resolved

src/libs/PolicyUtils.ts Outdated Show resolved Hide resolved

make functions generic

f7a00c5

hungvu193 approved these changes Jul 31, 2024

View reviewed changes

melvin-bot bot requested a review from deetergp July 31, 2024 15:20

hungvu193 approved these changes Jul 31, 2024

View reviewed changes

deetergp approved these changes Jul 31, 2024

View reviewed changes

deetergp merged commit de0c84f into Expensify:main Jul 31, 2024
15 of 16 checks passed

github-actions bot mentioned this pull request Aug 2, 2024

Deploy Checklist: New Expensify 2024-08-02 #46687

Closed

50 tasks

melvin-bot bot mentioned this pull request Aug 6, 2024

[HOLD for payment 2024-09-17] [$250] Add Offline and Error Patterns to Remaining Integrations #45406

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Offline and errors pattern in Sage Intacct integration #46294

Offline and errors pattern in Sage Intacct integration #46294

war-in commented Jul 26, 2024 •

edited

Loading

melvin-bot bot commented Jul 29, 2024

ikevin127 commented Jul 29, 2024

war-in commented Jul 30, 2024

hungvu193 commented Jul 30, 2024

hungvu193 commented Jul 30, 2024

hungvu193 commented Jul 31, 2024 •

edited

Loading

war-in commented Jul 31, 2024

hungvu193 left a comment

deetergp left a comment

OSBotify commented Jul 31, 2024

OSBotify commented Aug 2, 2024

OSBotify commented Aug 6, 2024

Offline and errors pattern in Sage Intacct integration #46294

Offline and errors pattern in Sage Intacct integration #46294

Conversation

war-in commented Jul 26, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 29, 2024

ikevin127 commented Jul 29, 2024

war-in commented Jul 30, 2024

hungvu193 commented Jul 30, 2024

hungvu193 commented Jul 30, 2024

hungvu193 commented Jul 31, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

war-in commented Jul 31, 2024

hungvu193 left a comment

Choose a reason for hiding this comment

deetergp left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 31, 2024

OSBotify commented Aug 2, 2024

OSBotify commented Aug 6, 2024

war-in commented Jul 26, 2024 •

edited

Loading

hungvu193 commented Jul 31, 2024 •

edited

Loading